Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix(ocm): exclude the local instance in the inviter select #11560

Merged
merged 1 commit into from
Sep 10, 2024
Merged

bugfix(ocm): exclude the local instance in the inviter select #11560

merged 1 commit into from
Sep 10, 2024

Conversation

fschade
Copy link
Collaborator

@fschade fschade commented Sep 10, 2024

Description

this fixes a bug where the local instance was listed in the inviter select.

Motivation and Context

reduce confusion by removing the current (users instance) from the inviter select.

Screenshots (if appropriate):

the current user is on https://ocis.ocm.i2:10200/

Screenshot 2024-09-10 at 10 03 20

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@fschade fschade force-pushed the bugfix-ocm-local-instance-check branch from b6bf62b to b5bdb45 Compare September 10, 2024 08:12
JammingBen
JammingBen reviewed Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your linter did something weird 🤔

packages/web-app-ocm/src/views/IncomingInvitations.vue Outdated Show resolved Hide resolved
@fschade fschade force-pushed the bugfix-ocm-local-instance-check branch 2 times, most recently from 7d6df3d to 4082877 Compare September 10, 2024 08:19
@fschade fschade force-pushed the bugfix-ocm-local-instance-check branch from 4082877 to 9fe099b Compare September 10, 2024 08:59
@fschade
Copy link
Collaborator Author

fschade commented Sep 10, 2024

Your linter did something weird 🤔

fixed... strange

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

JammingBen
JammingBen approved these changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for looking into this! 🚀

@JammingBen JammingBen merged commit 07ce361 into master Sep 10, 2024
3 checks passed
@JammingBen JammingBen deleted the bugfix-ocm-local-instance-check branch September 10, 2024 09:23
@micbar micbar mentioned this pull request Oct 1, 2024
Closed
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexAndBear AlexAndBear AlexAndBear approved these changes

@JammingBen JammingBen JammingBen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fschade @AlexAndBear @JammingBen