Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select all checkbox tiles view #11518

Merged
merged 9 commits into from
Sep 4, 2024
Merged

Select all checkbox tiles view #11518

merged 9 commits into from
Sep 4, 2024

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Sep 4, 2024 •
edited
Loading

Description

image

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • ...

JammingBen
JammingBen reviewed Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something messes with the right-click on tiles, it only works the first time for me.

packages/design-system/src/components/OcCheckbox/OcCheckbox.vue Show resolved Hide resolved
packages/web-pkg/src/components/FilesList/ResourceTiles.vue Outdated Show resolved Hide resolved
@JammingBen
Copy link
Collaborator

JammingBen commented Sep 4, 2024 •
edited
Loading

Something messes with the right-click on tiles, it only works the first time for me.

This is still an issue it seems like.

Edit: Ah sorry, you already noticed, didn't read your comment above.

@AlexAndBear AlexAndBear self-assigned this Sep 4, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@AlexAndBear AlexAndBear enabled auto-merge (squash) September 4, 2024 12:56
@AlexAndBear AlexAndBear merged commit 154e0d9 into master Sep 4, 2024
3 checks passed
@kulmann kulmann deleted the select-all-checkbox-tiles-view branch September 5, 2024 19:46
@micbar micbar mentioned this pull request Sep 12, 2024
Closed
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

@kulmann kulmann Awaiting requested review from kulmann

Assignees

@AlexAndBear AlexAndBear

Labels
None yet
Projects
Infinite Scale Team Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexAndBear @JammingBen