Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename search filters to 'current folder' and 'all files' #10340

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Rename search filters to 'current folder' and 'all files' #10340

merged 2 commits into from
Jan 16, 2024

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Jan 16, 2024 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • ...

@update-docs Update Docs
Copy link

update-docs bot commented Jan 16, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear changed the title Rename search filters to 'current folder Rename search filters to 'current folder' and 'all files' Jan 16, 2024
lookacat
lookacat approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@lookacat lookacat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼 , current folder seems to not be translated yet?

@AlexAndBear
Copy link
Contributor Author

LGTM 👍🏼 , current folder seems to not be translated yet?

Seems so

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 16, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@AlexAndBear AlexAndBear merged commit 35e6e0c into stable-8.0 Jan 16, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the issues/10339 branch January 16, 2024 14:33
ownclouders pushed a commit that referenced this pull request Jan 16, 2024
@AlexAndBear
Rename search filters to 'current folder' and 'all files' (#10340)
a2bef7a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

@lookacat lookacat lookacat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexAndBear @lookacat @JammingBen