Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webUI Provisioning tests for ldap users and groups #360

Merged
merged 1 commit into from
Jan 28, 2019

Conversation

dpakach
Copy link
Contributor

@dpakach dpakach commented Jan 24, 2019

Related Issue #343

Add webUI acceptance tests for checking what can/cannot happen with respect to modifying attributes of LDAP users and groups

@dpakach dpakach force-pushed the modify-ldap-attributes-webui branch from cb3f98c to bc468ea Compare January 24, 2019 11:26
@codecov
Copy link

codecov bot commented Jan 24, 2019

Codecov Report

Merging #360 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #360   +/-   ##
=========================================
  Coverage     35.74%   35.74%           
  Complexity     1333     1333           
=========================================
  Files            30       30           
  Lines          3752     3752           
=========================================
  Hits           1341     1341           
  Misses         2411     2411

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8cac2e...bc468ea. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 24, 2019

Codecov Report

Merging #360 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #360   +/-   ##
=========================================
  Coverage     35.74%   35.74%           
  Complexity     1333     1333           
=========================================
  Files            30       30           
  Lines          3752     3752           
=========================================
  Hits           1341     1341           
  Misses         2411     2411

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ab8e78...fb8e586. Read the comment docs.

skshetry
skshetry previously approved these changes Jan 25, 2019
Copy link
Member

@skshetry skshetry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

tests/acceptance/features/webUIProvisioning/users.feature Outdated Show resolved Hide resolved
When the administrator deletes user "user0" using the webUI and confirms the deletion using the webUI
Then user "user0" should not exist
And the deleted user "user0" tries to login using the password "%alt1%" using the webUI
And the user should be redirected to a webUI page with the title "%productname%"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
And the user should be redirected to a webUI page with the title "%productname%"
Then the user should be redirected to a webUI page with the title "%productname%"

tests/acceptance/features/webUIProvisioning/groups.feature Outdated Show resolved Hide resolved
.drone.yml Outdated Show resolved Hide resolved
.drone.yml Outdated Show resolved Hide resolved
.drone.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just small things.

@dpakach dpakach force-pushed the modify-ldap-attributes-webui branch 2 times, most recently from 6f3b8c5 to 38a7c3b Compare January 27, 2019 07:35
@dpakach dpakach force-pushed the modify-ldap-attributes-webui branch from 38a7c3b to fb8e586 Compare January 28, 2019 04:43
@individual-it individual-it merged commit f3241b6 into master Jan 28, 2019
@delete-merged-branch delete-merged-branch bot deleted the modify-ldap-attributes-webui branch January 28, 2019 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants