Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for checking if admin can modify LDAP defined attributes #341

Merged
merged 1 commit into from
Jan 15, 2019

Conversation

dpakach
Copy link
Contributor

@dpakach dpakach commented Jan 15, 2019

Related to issue #292
Acceptance tests for checking if modifying the attributes is blocked when LDAP attributes are set for those.

@codecov
Copy link

codecov bot commented Jan 15, 2019

Codecov Report

Merging #341 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #341   +/-   ##
=========================================
  Coverage     35.74%   35.74%           
  Complexity     1333     1333           
=========================================
  Files            30       30           
  Lines          3752     3752           
=========================================
  Hits           1341     1341           
  Misses         2411     2411

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac66ac4...78f8e54. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 15, 2019

Codecov Report

Merging #341 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #341   +/-   ##
=========================================
  Coverage     35.74%   35.74%           
  Complexity     1333     1333           
=========================================
  Files            30       30           
  Lines          3752     3752           
=========================================
  Hits           1341     1341           
  Misses         2411     2411

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac66ac4...ed9de8c. Read the comment docs.

@dpakach dpakach force-pushed the modify-ldap-attributes branch from 78f8e54 to ed9de8c Compare January 15, 2019 09:25
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
This is testing the behavior when trying to modify these attributes using occ commands.
I guess we also will need to test with the provisioning API and in the webUI.

@phil-davis phil-davis merged commit 240c93a into master Jan 15, 2019
@delete-merged-branch delete-merged-branch bot deleted the modify-ldap-attributes branch January 15, 2019 11:19
@phil-davis phil-davis mentioned this pull request Jan 15, 2019
4 tasks
@patrickjahns patrickjahns added this to the development milestone Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants