Drop PHP 7.2 #39
Merged
Drop PHP 7.2 #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil-davis
force-pushed
the
drop-php-7.2
branch
from
f06710a to
904ca85
Compare
dpakach
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for PHP 7.2 has been dropped in ownCloud core master. Upgrades to current core master (upcoming 10.9.0) need to use PHP 7.3 or PHP 7.4. PHP 7.4 is really the recommended version, so I used that. PHP 7.3 is already close to its end-of-life in December 2021.
See issue owncloud/core#39134 and PR owncloud/core#38697
Note: some upgrade combinations need different mixes of PHP 7.1 7.2 and 7.4. (I managed to avoid having to use PHP 7.3)