Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show qr on challenge page if not configured for the user #292

Merged
merged 4 commits into from
Jul 7, 2023
Merged

Show qr on challenge page if not configured for the user #292

merged 4 commits into from
Jul 7, 2023

Conversation

jvillafanez
Copy link
Member

@jvillafanez jvillafanez self-assigned this Jun 7, 2023
@CLAassistant
Copy link

CLAassistant commented Jun 7, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jvillafanez jvillafanez force-pushed the show_qr_on_challenge branch from f59a995 to 959c170 Compare June 7, 2023 12:01
@jvillafanez jvillafanez marked this pull request as ready for review June 7, 2023 16:03
@mrow4a mrow4a self-requested a review June 12, 2023 08:03
mrow4a
mrow4a reviewed Jun 12, 2023
View reviewed changes
Copy link

@mrow4a mrow4a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be good if you add comments to the code. it is not obvious this is used to enforce 2fa if needed

lib/Service/Totp.php Show resolved Hide resolved
lib/Provider/TotpProvider.php Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

phil-davis
phil-davis reviewed Jun 12, 2023
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - only one tiny comment change, so don't bother fixing that unless there are other things that need changing.

lib/Provider/TotpProvider.php
// If 2-factor is enforced, the challenge page will be accessed
// regardless of the user having configured the app or not.
// If the user doesn't have the app configured, we need to show
// the QR so the user is able to configured the app from the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// the QR so the user is able to configured the app from the
// the QR so the user is able to configure the app from the

mrow4a
mrow4a requested changes Jun 12, 2023
View reviewed changes
Copy link

@mrow4a mrow4a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clarify

lib/Service/Totp.php Show resolved Hide resolved
@mrow4a mrow4a self-requested a review June 13, 2023 14:32
@jvillafanez jvillafanez merged commit 8511cb3 into master Jul 7, 2023
@delete-merged-branch delete-merged-branch bot deleted the show_qr_on_challenge branch July 7, 2023 06:43
@jnweiger jnweiger mentioned this pull request Jul 12, 2023
Open
42 tasks
@jnweiger
Copy link
Contributor

https://github.com/owncloud/twofactor_totp/releases/download/v0.8.0-rc.1/twofactor_totp-0.8.0-rc.1.tar.gz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis left review comments

@mrow4a mrow4a mrow4a approved these changes

Assignees

@jvillafanez jvillafanez

Labels
3 - To review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jvillafanez @CLAassistant @jnweiger @phil-davis @mrow4a