Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Add label to OcSelect (port to master) #1633

Merged
merged 3 commits into from
Sep 6, 2021
Merged

Conversation

dschmidt
Copy link
Member

@dschmidt dschmidt commented Sep 4, 2021

Description

Ported #1570 to master.

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation added/updated

Open tasks:

  • ...

@dschmidt dschmidt force-pushed the master_label_for_ocSelect branch 3 times, most recently from fd6cdfb to f6b0c88 Compare September 4, 2021 21:26
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @kulmann what do you think?

changelog/unreleased/change-ocselect-label Outdated Show resolved Hide resolved
src/components/OcSelect.vue Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Sep 6, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

22.2% 22.2% Coverage
0.0% 0.0% Duplication

@kulmann kulmann merged commit 94c3683 into master Sep 6, 2021
@delete-merged-branch delete-merged-branch bot deleted the master_label_for_ocSelect branch September 6, 2021 12:56
This was referenced Sep 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Label option for ocSelect missing
3 participants