Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-CI] Remove OCS endpoint for group creation #7864

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

nabim777
Copy link
Member

@nabim777 nabim777 commented Dec 1, 2023

Description

In this PR, provision API is removed for group creation

Related Issue

Motivation and Context

The group is unable to create using the provision endpoint since it has been removed from test also.

curl -k -v "https://localhost:9200/ocs/v2.php/cloud/groups" --data '{"grouped" : "sales"}' -u admin:admin

Output

*   Trying 127.0.0.1:9200...
* Connected to localhost (127.0.0.1) port 9200 (#0)
.
.
.
> POST /ocs/v2.php/cloud/groups HTTP/1.1
> Host: localhost:9200
> Authorization: Basic YWRtaW46YWRtaW4=
> User-Agent: curl/7.81.0
> Accept: */*
> Content-Length: 19
> Content-Type: application/x-www-form-urlencoded
> 
* TLSv1.2 (IN), TLS header, Supplemental data (23):
* TLSv1.3 (IN), TLS handshake, Newsession Ticket (4):
* TLSv1.2 (IN), TLS header, Supplemental data (23):
* Mark bundle as not supporting multiuse
< HTTP/1.1 404 Not Found
< Content-Length: 19
< Content-Type: text/plain; charset=utf-8
< Date: Tue, 12 Dec 2023 06:30:15 GMT
< Ocs-Api-Version: 2
< Vary: Origin
< X-Content-Type-Options: nosniff
< X-Request-Id: nabin-OptiPlex-3050/NhbdoFu8HO-006552
< 
404 page not found
* Connection #0 to host localhost left intact

How Has This Been Tested?

  • locally
  • ci

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nabim777 nabim777 force-pushed the remove-ocs-endpoint branch 2 times, most recently from d3a50c3 to e70333e Compare December 18, 2023 06:34
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other LGTM 👍

Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

sonarcloud bot commented Dec 19, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@saw-jan saw-jan merged commit 8ce0417 into master Dec 19, 2023
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the remove-ocs-endpoint branch December 19, 2023 08:40
ownclouders pushed a commit that referenced this pull request Dec 19, 2023
2403905 pushed a commit to 2403905/ocis that referenced this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants