Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update reva to v1.2.2-0.20200924071957-e6676516e61e #601

Merged
merged 4 commits into from
Sep 24, 2020

Conversation

butonic
Copy link
Member

@butonic butonic commented Sep 24, 2020

related issues fixed on ocis driver:
https://github.com/owncloud/ocis-reva/issues/262
https://github.com/owncloud/ocis-reva/issues/357
https://github.com/owncloud/ocis-reva/issues/301
https://github.com/owncloud/ocis-reva/issues/302

@butonic butonic requested a review from refs September 24, 2020 10:11
@butonic butonic self-assigned this Sep 24, 2020
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@butonic
Copy link
Member Author

butonic commented Sep 24, 2020

@LukasHirt I need help with the web ui tests:

15) Scenario: logging out redirects to the url with state attribute (attempt 1, retried) # tests/acceptance/features/webUILogin/login.feature:30
--
4603 | ✔ Before # tests/acceptance/setup.js:28
4604 | ✔ Before # tests/acceptance/setup.js:32
4605 | ✔ Before # tests/acceptance/setup.js:36
4606 | ✔ Before # tests/acceptance/setup.js:46
4607 | ✔ Before # tests/acceptance/setup.js:68
4608 | ✔ Before # tests/acceptance/setup.js:75
4609 | ✔ Before # tests/acceptance/stepDefinitions/filesContext.js:18
4610 | ✔ Before # tests/acceptance/stepDefinitions/generalContext.js:228
4611 | ✔ Before # tests/acceptance/stepDefinitions/generalContext.js:267
4612 | ✔ Given these users have been created with default attributes: # tests/acceptance/stepDefinitions/provisioningContext.js:194
4613 | \| username \|
4614 | \| user1    \|
4615 | ✖ And user "user1" has logged in using the webUI # tests/acceptance/stepDefinitions/loginContext.js:67
4616 | Timed out while waiting for element <#oc-app-container> to be present for 20000 milliseconds. - expected "visible" but got: "not found" (20006ms)
4617 | at _callee$ (/srv/app/phoenix/tests/acceptance/helpers/loginHelper.js:31:8)
4618 | at processTicksAndRejections (internal/process/task_queues.js:86:5)
4619 | - And the user has browsed to the files page # tests/acceptance/stepDefinitions/filesContext.js:82
4620 | - When the user logs out of the webUI # tests/acceptance/stepDefinitions/loginContext.js:71
4621 | - Then the user should be on page with the url containing "/#/login?state=" # tests/acceptance/stepDefinitions/loginContext.js:62
4622 | - When user "user1" logs in using the webUI # tests/acceptance/stepDefinitions/loginContext.js:34
4623 | - Then the files table should be displayed # tests/acceptance/stepDefinitions/filesContext.js:78
4624 | ✔ After # tests/acceptance/stepDefinitions/provisioningContext.js:221
4625 | ✔ After # tests/acceptance/stepDefinitions/generalContext.js:272
4626 | ✔ After # tests/acceptance/stepDefinitions/generalContext.js:252
4627 | ✔ After # tests/acceptance/setup.js:110
4628 | ✔ After # tests/acceptance/setup.js:106
4629 | ✔ After # tests/acceptance/setup.js:102
4630 | ✔ After # tests/acceptance/setup.js:95
4631 | ✔ After # tests/acceptance/setup.js:86
4632 | ✔ After # tests/acceptance/setup.js:54

AFAICT the user1 was not created in time ...

Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@micbar
Copy link
Contributor

micbar commented Sep 24, 2020

@butonic it is green!

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - less test scenarios are failing.

@butonic butonic merged commit 3389c48 into owncloud:master Sep 24, 2020
@butonic butonic deleted the update-reva-to-20200924 branch June 8, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants