-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deps for reva #328
Update deps for reva #328
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
For the record, here is the progress that led to this PR:
|
for the record, those two related references were mentionned by @refs in a chat: |
I've tried many combinations of replacement for etcd, even removing it from the top and keeping only in the replace section, but all are giving the errors at compilation time. |
I just had another look at the original code that mentionned the workaround, which is in etcd-io/etcd#11563 (comment) and as far as I can see the first statement is commented out, so I removed it. I've pushed and now the error becomes:
|
This reverts commit 0e36b87.
In ocis we currently face the problem that some of our dependencies rely on grpc 1.26.0. With the upgraded grpc dependency in reva we were unable to build ocis. And if we upgrade grpc in ocis the build failed because of the other dependency. I hoped we could downgrade grpc in reva until we have found a better long term solution. Here are some examples of our attempts to resolve this without this downgrade. owncloud/ocis#328 (comment) Signed-off-by: David Christofas <[email protected]>
In ocis we currently face the problem that some of our dependencies rely on grpc 1.26.0. With the upgraded grpc dependency in reva we were unable to build ocis. And if we upgrade grpc in ocis the build failed because of the other dependency. I hoped we could downgrade grpc in reva until we have found a better long term solution. Here are some examples of our attempts to resolve this without this downgrade. owncloud/ocis#328 (comment)
obsolete, grpc version was downgraded in reva |
* Update reva to v0.1.1-0.20200701152626-2f6cc60e2f66 * update the api tests to core commit a3cac3dad60348fc962d1d8743b202bc5f79596b Co-authored-by: Michael Barz <[email protected]>
Attempt to update deps for future reva, based on the deps commit in #323 and an addition to fix grpc version to fix compilation issue.