-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update reva #3175
update reva #3175
Conversation
💥 Acceptance test localApiTests-apiSpaces-ocis failed. Further test are cancelled... |
@C0rby I think this should be fixed if you rebase to latest master |
Thanks! |
a92356a
to
152b337
Compare
Kudos, SonarCloud Quality Gate passed! |
The JSON response to a "list spaces" request no longer includes the structure "owner - user - id". A space has users who have the "manager" role. There is not a single "owner" of a space. I adjusted the failing test so that it looks for the "manager" role permission. Note: the requirement of these sort of tests (existing tests, and the test that I adjusted) are rather brittle, because they specify the index "0", "1" etc where the permission/role appears in the array of user permissions/roles. That breaks if the permissions array is returned in a different order, which is not a good thing. We are thinking about how best to refactor that so that tests are less brittle see issue #3179 |
Thanks @phil-davis for taking care. I wanted to take a look today but since you've already dealt with it we can just continue with the oCIS release. 👍 💪 |
Updated reva to latest edge.
This includes the implementation for #2986