Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove csp from web service and let proxy service handle it #10146

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

jvillafanez
Copy link
Member

Description

There is a duplicate CSP being sent. This PR removes the CSP from the web service, so only the one from the proxy service remains.

Related Issue

#10042

Motivation and Context

The duplicate CSP is causing problems

How Has This Been Tested?

Manually tested following the steps in the linked issue. Checked that the response for the root page has only one CSP header (coming from the proxy service)

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@jvillafanez jvillafanez self-assigned this Sep 24, 2024
Copy link

update-docs bot commented Sep 24, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link

sonarcloud bot commented Sep 24, 2024

@jvillafanez jvillafanez merged commit 2dc20e9 into master Sep 25, 2024
4 checks passed
@jvillafanez jvillafanez deleted the remove_csp_from_web branch September 25, 2024 08:21
ownclouders pushed a commit that referenced this pull request Sep 25, 2024
fix: remove csp from web service and let proxy service handle it
@micbar micbar mentioned this pull request Oct 1, 2024
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants