[tests-only] Update drone starlark and drop PHP 7.2 #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil-davis
force-pushed
the
drone-star-20210914
branch
from
d700735 to
5abbefb
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
kiranparajuli589
approved these changes
Sep 14, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of issue owncloud/QA#687
In the 2nd commit, I have reverted the changes to
owncloudci/nodejs:14for running the JS tests. For some reason, the JS tests in the notes app do not pass with the new nodejs 14 docker image. I raised issue #405 to look into that.For now, we can get all the other "drop PHP 7.2" etc changes merged.