Search provider #159
Search provider #159
Conversation
This allow the playblack of artists/albums/tracks by URL.
| @@ -72,6 +72,13 @@ public function findByName($artistName, $userId){ | |||
| } | |||
| return $this->findEntity($sql, $params); | |||
| } | |||
|
|
|||
| public function findByNameLike($pattern, $userId){ | |||
There was a problem hiding this comment.
I also added such a function (with test coverage) on my ampache branch. I will try now to port those features, that unrelated to ampache, to the master branch and then you can use it for your code. Is this okay for you?
|
It is done. There is an error in the commit message : Use of the new mapper method ' |
Where? |
|
I just wanted to say that I used a wrong name (getAllByName) in the comment of my commit. |
|
@leizh I would like if different features/enhancements/bug-fixes are in separate PRs. This makes the review process easier and more straight forward. I will first cherry pick the search provider from this branch and test it. then you maybe need to describe the AngularJS fixes to me (especially: what is the problem?) Anyways: Thanks for your work. |
|
@leizh Got it... that are the routes. Will try to understand your changes. |
|
@leizh I have merged your stuff and fixed some minor issues. 11739d9...743f241 The issues are:
|
I am not familiar with AngularJS. If you think there is a better way to do this, let me know.
The playback of artists/albums/tracks is handled by the MainController while the playback by file is in PlayerController. PlayerController could handle all the playback requests by route change. In this case, the MainController would have only the "play" method for the template.