-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Subsonic] getArtistInfo doesn't work with song id #906
Comments
Please let me now! |
Actually, we don't currently handle the case of album IDs, either. I hadn't noticed that the API spec defines the argument like that, as the other similar method Do you know any Subsonic client which would try to use |
My own Soundwaves (https://apps.apple.com/app/soundwaves/id736139596) uses getArtistInfo with track ID, to show some details about the currently playing track, if the user requests them. It can't pass the artist ID since Subsonic doesn't provide it for tracks. If you need a promo code to test it, just let me know and I'll email it to you. |
Okay, thanks for the info. I don't have any Apple devices to test with so that explains why I haven't seen any problem.
Are you sure about that? At least the Subsonic demo server seems to include the property It should be noted, though, that this |
that bit was not quite clear to me from the docs. However |
According to the Subsonic API documentation, it should be possible to call `getArtistInfo` also with an ID pointing to an album or a track. On the other hand, `getArtistInfo2` is not specified to have such support, but we provide it anyway, because we use a shared implementation for both of these functions (the real Subsonic server couldn't do this because it doesn't use ID prefixes, making some of the different ID types indistinguishable from each other). Also, the the function now supports fetching the artist info with a folder ID. This may be relevant when browsing the library by folders. In this case, the info is fetched based on the folder name; if there is an artist in the DB with the same name as the folder, then the info can be fetched. refs #906
Okay, I see. The Subsonic API can be a bit awkward to use with its ID3/filetree duality. And the Music app's implementation of the API is yet another story because of the different starting point and somewhat different design philosophy. But anyways, I have now made a fix for this. So when the next Music app release rolls out probably withing a couple of weeks, the Thanks for reporting the issue! |
Music v1.4.1 is now out, including also this fix/enhancement. |
is this already fixed? |
@erwinlagu Yes, as stated above: #906 (comment) |
Subsonic API docs specify that getArtistInfo can be called with "The artist, album or song ID.", but the Music app only handles the first two cases.
The text was updated successfully, but these errors were encountered: