Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Music v.1.3.1 breaks Subsonic Soundwaves Player - Nextcloud v.21.0.4 #885

Closed
atkinsom opened this issue Aug 31, 2021 · 6 comments
Closed

Upgrade to Music v.1.3.1 breaks Subsonic Soundwaves Player - Nextcloud v.21.0.4 #885

atkinsom opened this issue Aug 31, 2021 · 6 comments
Labels
Bug

Comments

@atkinsom
Copy link

Hi,

I just upgraded to Music v.1.3.1 on Nextcloud v.21.0.4 and when I try to use my Soundwaves Subsonic player on my iPhone to select songs I get the following error "Server Error - There was a problem with your request: Required parameter 'musicFolderId' missing"

The test within the app confirms that I can connect successfully but when I try to tap to select songs I get the error above. I've included an attachment to assist with any troubleshooting. Thanks again for a great app.
IMG_0973
paulijar added a commit to paulijar/music that referenced this issue Aug 31, 2021
@paulijar
Subsonic: Fix arg musicFolderId on getIndexes not being optional
95cf209 
The argument `musicFolderId` of the method `getIndexes` ought to be
optional according to the API specification, but it was mistakenly
marked as "required" on the commit 4f32308. This broke the
compatibility with the Soundwaves Player and prevented using the "All
Folders" selection on many other players, e.g. DSub and Subsonic Music
Streamer.

refs owncloud#885
@paulijar
Copy link
Collaborator

Thanks for the report. It seems that I have accidentally marked an argument as required when it ought to be optional. The fix requires just one ? character if you wish to monkey patch your installation while waiting for the fix release. See the commit linked above for details.

@paulijar paulijar added the Bug label Aug 31, 2021
@atkinsom
Copy link
Author

Thank you very much. Your suggestion worked like a charm. Cheers

@jecogeo
Copy link

jecogeo commented Sep 2, 2021

Just to let you all know, I'm having the same issue. However, I'm streaming via subsonic to a different client and the error is also different. I'm using play:Sub (iOS) and the message is "Token-based auth not supported". I use TOTP authentication on my NC instance and I'm streaming with no problem for months. Now I updated the app to 1.3.1 I'm facing this. Should I open another issue?

@paulijar
Copy link
Collaborator

paulijar commented Sep 2, 2021 •
edited
Loading

@jecogeo Your issue is actually separate and already reported once in #886, see that issue for the description and the solution.

@jecogeo
Copy link

jecogeo commented Sep 2, 2021

@jecogeo Your issue is actually separate and already reported once in #886, see that issue for the description and the solution.

You're right! Thanks a lot!

@paulijar
Copy link
Collaborator

paulijar commented Sep 5, 2021

The fix for this issue is now released in Music v1.3.2

@paulijar paulijar closed this as completed Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jecogeo @paulijar @atkinsom and others