Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement : add desktop notification #828

Closed
Talw3g opened this issue Feb 16, 2021 · 3 comments
Closed

Enhancement : add desktop notification #828

Talw3g opened this issue Feb 16, 2021 · 3 comments
Labels
Enhancement

Comments

@Talw3g
Copy link

Talw3g commented Feb 16, 2021

Hello,
I'm used to the desktop app "Musicbee" on win10, which displays a small notification when playing a new song with some basic info about it : album art, artist, song, year...
And I think it would be a nice feature to Music too ! I know NC already has the ability to display desktop notifications, so I'm hoping it's not too hard to implement... :)

Anyway, thank you for this wonderful app ! It does what it's supposed to, and it does it well !
@michaeljalves
Copy link

Internet radio stations also broadcast metadata showing Artist/Album/Song. It would be great to see that in the header if possible.

@paulijar
Copy link
Collaborator

@Talw3g Thanks for the suggestion. I'll try to find time to investigate this at some point. If such notification is added, it might be better to offer also a user-setting to opt out of it. I can imagine that some users would find it annoying, while they still would want to keep other desktop notifications from Nextcloud.

@michaeljalves Your request is separate from the original request here, and it is now followed in #829. But of course, if both the desktop notification would be added, and the song info from the radio station could be extracted, then also combining these two would make sense.

paulijar added a commit that referenced this issue Apr 5, 2021
@paulijar
Show a desktop notification when the playing song changes
53f7fef 
refs #828
paulijar added a commit that referenced this issue Apr 6, 2021
@paulijar
Show only one desktop notification at time
c111668 
The previous desktop notification is now always closed when a new one
is opened. On desktop browsers, this makes a difference only when the
playing song changes in rapid succession, and the popup has no time to
close automatically before the new one is presented. On Firefox for
Android, all the notifications stay in the notification center
indefinitely, and this change prevents them from piling up.

Also, debounce of 500ms is now applied before showing the notification.
This is because programmatically closing the notification doesn't work
right after it has been spawned. Hence, rapidly tapping the "Skip next"
button still made the notifications pile up.

refs #828
paulijar added a commit that referenced this issue Apr 17, 2021
@paulijar
Add a setting to disable desktop notifications on song change
ac1538b 
refs #828
@paulijar
Copy link
Collaborator

The desktop notifications feature is now released in Music v1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@paulijar @Talw3g @michaeljalves