-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Artist Images #1164
Comments
I ran a occ music scan command and images are indeed showing up! Although I'm not sure which file is being picked among the 2. |
Silly me - thought the * at the end was as is but it is just indicating the extension of the image - .jpg .png etc. Problem solved! |
Yeah, any image file format known by Nextcloud will do and the |
With PostgreSQL, uploading an image file caused an unhandled exception Doctrine\DBAL\Exception\DriverException in case the target folder contained songs of more than one album. Hence, the uploaded image wasn't immediately used as a cover art for any album or artist. For album covers, the image was pulled later by the background task but for artist cover, the file could be detected only by running a new library scan. The root cause was that the way used to handle the parameters of the SQL query wasn't compatible with PgSQL. refs #1164
I did some testing, and indeed, I found a bug which could cause the automatic use of the uploaded cover art image to fail with PostgreSQL. This problem manifested itself in case the target folder contained audio files of more than one albums. In that case, there was an unhandled exception shown in the nextcloud.log after the image file upload: Do you think that you have hit this same bug? Can you find such an error from the log (the input shown in the end of the message would surely be different for you)? Anyway, I made a fix for this so this problem should be gone upon the next Music app release. |
Thank you so much for your response. My log is filled with these entries - "[core] Error: Exception thrown: Doctrine\DBAL\Exception |
Those log entries are probably not related to this artists image issue since those entries haven't been created in the context of the Music app but when the cloud core has created the thumbnail image for some file. |
New Music version 2.0.1 now contains fix for the PostgreSQL issue I mentioned above. Please reopen this or a new issue in case you find that something is still off with the artist image handling. |
Steps to reproduce
Example - for Bon Jovi - I upload two images, one with "Bon Jovi.*" and the other "Bon Jovi.jpg". Neither works unfortunately
Expected behaviour
Artist image to be pulled from the directory
Art
Tell us what should happen - Artist image to be pulled from the directory
Actual behaviour - Artist image does not show up.
Tell us what happens instead
Server configuration
Operating system: Truenas Scale 24.0.2 Dragonfish
Web server: APACHE II
Database: Postgresql 13.1
PHP version: 8.2.22
ownCloud version: (see ownCloud admin page) - Nextcloud version 29.0.4
The text was updated successfully, but these errors were encountered: