Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable session timeout for the Ampache API #1134

Closed
paulijar opened this issue Mar 14, 2024 · 3 comments
Closed

Configurable session timeout for the Ampache API #1134

paulijar opened this issue Mar 14, 2024 · 3 comments
Labels
6 - Ready for release Fix or feature is ready and will be included in the next release Enhancement

Comments

@paulijar
Copy link
Collaborator

Currently, the session timeout for the Ampache API has been hard-coded to 6000 seconds (1 hour 40 minutes). This value could be made configurable. As this is a rather technical detail with some security implications, I would allow only the cloud admins to configure it via config.php and not add any user-setting.

This was first requested at mitchray/ample#44 (comment).
@paulijar paulijar mentioned this issue Mar 14, 2024
Closed
@rstefko
Copy link
Contributor

rstefko commented Mar 19, 2024

Thank you. Btw. the API tokens can only be used with ownCloud Music APIs right?

@paulijar
Copy link
Collaborator Author

Yes, the API tokens only allow access to the Ampache and Subsonic APIs of the Music app if that was what you meant. So if those keys are leaked, then the damage made is limited.

paulijar added a commit that referenced this issue Mar 29, 2024
@paulijar
Make the ampache session timeout configurable for the cloud admins
35559fa 
The timeout can now be set with the `config.php` key
`music.ampache_session_expiry_time`. The default is 6000 seconds and
maximum is 31536000 seconds, equaling one year. The maximum has been
limited to prevent overflow especially with PostgreSQL where the expiry
timestamp (as Unix epoch time) cannot exceed 2^31-1 (which equals a
date in the year 2038).

refs #1134
@paulijar paulijar added the 6 - Ready for release Fix or feature is ready and will be included in the next release label Mar 29, 2024
@paulijar
Copy link
Collaborator Author

This feature is now released in Music v1.11.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
6 - Ready for release Fix or feature is ready and will be included in the next release Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rstefko @paulijar