Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the following languages: #38

Merged
merged 3 commits into from
Jan 24, 2019

Conversation

javiergonzper
Copy link
Contributor

Description

Added the following languages:

  • cs_CZ
  • de
  • de_DE
  • en_GB
  • ko
  • mk
  • nb_NO
  • nn_NO
  • pt_BR
  • pt_PT
  • ru
  • sq
  • th_TH
  • zh_CN

There are only changes on:

  • Project (supported new languages)
  • .tx/config to make the mapping from Transifex to Xcode

Related Issue

owncloud/ios-app#202

Motivation and Context

How Has This Been Tested?

Once it has been merged to master we will check if the languages are updated correctly

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

cs_CZ de de_DE en_GB ko mk nb_NO nn_NO pt_BR pt_PT ru sq th_TH zh_CN
@michaelstingl
Copy link
Contributor

Can't judge the technical side. @hosy could you have a look?

@michaelstingl michaelstingl added this to the 0.4.0 milestone Jan 22, 2019
@codecov
Copy link

codecov bot commented Jan 24, 2019

Codecov Report

Merging #38 into master will decrease coverage by 3.36%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
- Coverage   76.61%   73.25%   -3.37%     
==========================================
  Files         186      184       -2     
  Lines       16554    15451    -1103     
==========================================
- Hits        12683    11318    -1365     
- Misses       3871     4133     +262
Impacted Files Coverage Δ
ownCloudSDK/File Handling/OCFile.m 0% <0%> (-100%) ⬇️
...wnCloudSDK/Resource Management/OCBookmarkManager.m 0% <0%> (-100%) ⬇️
...DK/Core/Sync/Actions/Update/OCCore+CommandUpdate.m 0% <0%> (-100%) ⬇️
...ertificate Metadata/OCCertificateDetailsViewNode.m 0% <0%> (-64.5%) ⬇️
ownCloudSDK/Resource Management/OCCoreManager.m 8.49% <0%> (-59.11%) ⬇️
...dMocking/Mocking Targets/OCCoreManager+OCMocking.m 33.33% <0%> (-55.56%) ⬇️
...dSDK/Core/Sync/Actions/Update/OCSyncActionUpdate.m 0% <0%> (-55.43%) ⬇️
ownCloudSDK/Query/OCQueryFilter.m 0% <0%> (-44.45%) ⬇️
ownCloudSDKTests/OCTestTarget.m 66.66% <0%> (-33.34%) ⬇️
ownCloudSDK/Toolkit/OCProcessSession.m 56.52% <0%> (-24.73%) ⬇️
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72318f0...e307545. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 24, 2019

Codecov Report

Merging #38 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
- Coverage   76.68%   76.67%   -0.02%     
==========================================
  Files         186      186              
  Lines       16554    16554              
==========================================
- Hits        12695    12693       -2     
- Misses       3859     3861       +2
Impacted Files Coverage Δ
ownCloudSDK/Resource Management/OCCoreManager.m 69.27% <0%> (-1.68%) ⬇️
...K/Core/Connection Status/OCCore+ConnectionStatus.m 85.61% <0%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72318f0...e307545. Read the comment docs.

@javiergonzper javiergonzper merged commit 84427e9 into master Jan 24, 2019
@delete-merged-branch delete-merged-branch bot deleted the feature/support_new_languages_tx branch January 24, 2019 12:12
felix-schwarz added a commit that referenced this pull request Feb 1, 2019
commit 6808431
Author: Felix Schwarz <[email protected]>
Date:   Thu Jan 31 11:05:17 2019 +0100

    - Single item queries: take into account that if items are moved on the server, and they haven't come into view at their new location yet, they may temporarily appear as removed

commit aaaf9be
Merge: 538c6ac dd45ed0
Author: Felix Schwarz <[email protected]>
Date:   Wed Jan 30 21:30:56 2019 +0100

    Merge remote-tracking branch 'origin/master' into develop

commit 538c6ac
Author: Felix Schwarz <[email protected]>
Date:   Wed Jan 30 21:27:58 2019 +0100

    - OCCoreServerStatusSignalProvider
            - new name for OCCoreMaintenanceModeStatusSignalProvider
            - added handling and automatic recovery from "Connection refused" errors with custom status message
    - OCConnection
            - extension of delegate method for connection request instructions
    - OCCore
            - check for "connection refused" errors, reporting and automatic recovery using OCCoreServerStatusSignalProvider

commit dd45ed0
Author: Javier Gonzalez <[email protected]>
Date:   Wed Jan 30 20:52:41 2019 +0100

    - Added th-TH to the .tx config (#39)

    - Updated the th translations pushed recently to the right folder

commit bf2fdf0
Author: Felix Schwarz <[email protected]>
Date:   Wed Jan 30 17:21:59 2019 +0100

    - OCCore+ItemList
            - preserve LocalID (and local copies) when files are moved on the server by looking up the fileID of supposedly new items (previously would create a new localID for the moved item)
            - new OCDatabase method for retrieving items with a particular fileID, even it is was previously marked as deleted (quite common with certain move operations on the server)
    - OCCore+ItemUpdates
            - fixes for single-item queries
            - single-item queries now also use LocalID in addition to the path
    - Bookmarks
            - OCBookmark: new OCBookmarkUpdatedNotification notification so any part of the SDK can request that a particular bookmark's data be persisted if necessary
            - OCBookmarkManager: now listens for OCBookmarkUpdatedNotification and saves the bookmark if it receives a notification for a bookmark it manages
            - OCConnection: posts OCBookmarkUpdatedNotification if users approve a changed certificate so the changes are persisted

commit 613bf6c
Author: Felix Schwarz <[email protected]>
Date:   Wed Jan 30 13:23:38 2019 +0100

    - Sync Engine
            - changed cancellable flag of NSProgress objects for all actions, so that only up- and downloads are cancellable until the other actions fully support that
            - sync engine now blocks the OCCore queue while running
            - added sync journal dumps before and after entering processing, and after the processing of every journal entry (debug log-level only)
    - Upgraded most table schemas - especially metaData and syncJournal - from "INTEGER PRIMARY KEY" to "INTEGER PRIMARY KEY AUTOINCREMENT" to avoid the reuse of IDs by SQLite (including migrations)

commit 4195955
Author: ownClouders <[email protected]>
Date:   Wed Jan 30 09:48:03 2019 +0000

    [tx] updated from transifex

commit ed2969d
Author: Felix Schwarz <[email protected]>
Date:   Tue Jan 29 11:11:46 2019 +0100

    - OCCore
            - fixed order in which progress is removed and the observers on progress are removed
            - made sure observers aren't removed from inside -observeValueForKeyPath:
    - OCSyncActionDownload and OCSyncActionUpload
            - now registered the sync record's progress instead of the connection's

commit 4617829
Author: ownClouders <[email protected]>
Date:   Tue Jan 29 05:00:38 2019 +0000

    [tx] updated from transifex

commit 36e4ea5
Author: Felix Schwarz <[email protected]>
Date:   Tue Jan 29 00:25:00 2019 +0100

    - Add OCItem.cloudStatus computed property indicating the cloud status of the item
    - Fix OCCore progress tracking bugs

commit ab78777
Author: Felix Schwarz <[email protected]>
Date:   Mon Jan 28 10:30:04 2019 +0100

    - OCActivity
            - fill API gaps
            - implement missing pieces of OCSyncRecordActivity
            - OCCoreItemListTask now is an OCActivitySource, OCCore+ItemList now emits activity updates
    - OCCore
            - use localID instead of fileID to track progress on a per-item basis
            - now posts OCCoreItemBeginsHavingProgress and OCCoreItemStopsHavingProgress notifications when an item starts having progress, and when the last progress has completed for an item
            - add localID property to NSProgress
    - Sync Engine
            - OCSyncAction now properly serialized/deserializes the localizedDescription
            - gated access to OCDatabase for adding, updating and removing SyncRecords, used to emit activity updates

commit 8dcda9c
Author: Felix Schwarz <[email protected]>
Date:   Sat Jan 26 16:48:25 2019 +0100

    - New activity tracking subsystem
            - OCActivityManager
                    - keeps track of activities
                    - coalesces updates for maximum performance
                    - relays activity information to main thread
            - OCActivity
                    - describes an activity with description, status message, progress
                    - provides cancel option
                    - can contain an OCIssue for error resolution
            - OCActivityUpdate
                    - encapsulates activity update information
                    - allows publishing and unpublishing activities
                    - allows update of individual activity properties
            - simplified creation of OCActivity objects and updates via the OCActivitySource protocol
    - OCConnection
            - trying to upload a non-existant file now results in an error
            - extended internal error checks in uploadFileFromURL:
    - OCCore+ItemList
            - experimental supply of activity information for background updates
    - OCCore+LocalImport
            - addition of a import transformations
            - used by the FileProvider to transform select bundle document formats into ZIP archives on the fly
    - OCSyncRecord
            - adding OCActivitySource conformance

commit 5c8ea2d
Author: ownClouders <[email protected]>
Date:   Fri Jan 25 05:00:37 2019 +0000

    [tx] updated from transifex

commit 58d5397
Author: Felix Schwarz <[email protected]>
Date:   Thu Jan 24 17:11:41 2019 +0100

    - Fix duplicate item issue (placeholder + item from server) in case of copying a folder while a query retrieves the copied file briefl before copying returns
    - Switched OCSyncExec / OCSyncExecDone to semaphores for increased efficiency
    - Extended TestTools.databaseSanityCheckFilter with dumping the creation history stacktrace of items raising an error

commit af00e58
Author: Felix Schwarz <[email protected]>
Date:   Thu Jan 24 16:09:13 2019 +0100

    - Make OCBookmarkManager.bookmarks a non-mutable array

commit 84427e9
Author: Javier Gonzalez <[email protected]>
Date:   Thu Jan 24 13:12:07 2019 +0100

    Added the following languages: (#38)

    cs_CZ de de_DE en_GB ko mk nb_NO nn_NO pt_BR pt_PT ru sq th_TH zh_CN

commit 72318f0
Author: ownClouders <[email protected]>
Date:   Thu Jan 24 05:03:17 2019 +0000

    [tx] updated from transifex

commit 8183876
Author: Felix Schwarz <[email protected]>
Date:   Wed Jan 23 17:30:56 2019 +0100

    - Introducing OCLocalID
            - an ID issues locally by the SDK for every item that does not change for the lifetime of the item (including transitions from placeholder to item on the server)
            - added OCItem.localID and OCItem.parentLocalID properties (+ serialization/deserialization)
            - added +[OCItem generateNewLocalID] for the generation of new localIDs
            - updated OCSyncActions
                    - greatly simplified OCSyncActionUpload as files no longer need to be moved when transitioning from placeholder to item on the server
            - updated OCDatabase
                    - updated metadata table schema with localID column
                    - updated syncRecords table schema with localID column
                    - updated methods accordingly
                    - new OCDatabase.itemFilter API to run on all items as they are added, updated and removed from the database
            - updated CoreTests and CoreSyncTests
                    - added localID sanitizer to the OCDatabase of all tests (using new OCDatabase.itemFilter feature)
                    - updated all tests to verify that localIDs stay intact across actions and queries
            - update OCCoreItemList to also offer sets and dictionaries of items by localID
            - drafted new API for OCSyncAction to alllow coalescing of unexecuted sync records using the localID as connecting element
            - upgraded query updates to detect moved files using the localID of an updated item
            - changed FileProvider-related methods to use the localID instead of the fileID as NSFileProviderItemIdentifier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants