Handle file firewall forbidden message and show it to the user.

[SergioBertolinSG]

Currently iOS client is not showing the user what happened if the server blocks access by firewall.

To block the iOS client add a rule in the file firewall of the server (enterprise only) like this:

For example the desktop client blocked by firewall:

cc: @nasli @rperezb

• [GIT] Create branch manage_new_error_messages on the main app
• [GIT] Create branch manage_new_error_messages_library on the library
• [DEV] Modify the XML parser to detect the "Message field"
• [DEV] Refactor the code to manage all the errors on all the request with the same method
• [DEV] Return the error message inside the NSError for special cases like Firewall
• [DEV] Use the new Error code OCErrorForbidenUnknow to show the right error message on the uploads view
• [DEV] Control on the ManageErrros class the OCErrorForbidenUnknow to show the right error on all the cases
• [DEV] Use the string from the server instead a translated message
• [DEV] Show the right error on the Login View
• [DEV] Show the right error when we make a download
• [DEV] Show the right error when the user try to upload a file
• [DEV] Show the right error on the Document Provider
• [DEV] Show the right error on the Share In
• [BUG] Show different error message when firewall blocks than when user doesn't have write permission in the folder ( Handle file firewall forbidden message and show it to the user. #494 (comment) ) [FIXED]
• Not clear message when downloading with a firewall rule [FIXED]
• [QA] Create test plan
• [QA] Validate test plan @jesmrec
• [GIT] Merge branch manage_new_error_messages on the main app
• [GIT] Merge branch manage_new_error_messages_library on the library

PR:#851
PR library: owncloud/ios-library#148

[nasli]

The server is using the same code status for many different errors. The desktop client is showing the message that receive from the server, but what happen if you have other language, the error message shown in another language... not cool, we have to think to use different code status.

[SergioBertolinSG]

cc @nickvergessen

[javiergonzper]

In our login view we should show the "firewall error" in the same place where we show a login error.
Also maybe we could receive the error after the login because the admin can activate the firewall after the user log in.

[nickvergessen]

The desktop client is showing the message that receive from the server, but what happen if you have other language.

The server response in the language that the user selected.

The status is 403 - Forbidden is the only status code that matches.

[jesmrec]

Needed a review of the status flow for the banned uploads. Right now we have different behaviours depending of the rule/issue that bans the upload.

CC @nasli

[nasli]

Agree @jesmrec.

Summarizing, after an error is detected, the upload should fail and have the chance to retry.

[jesmrec]

Checking this again.

the firewall error is also shown when a user can not upload to a non-granted-shared-folder.

[davivel]

Fixing last loose end...

[davivel]

Fixed messages, @jesmrec please test.

[jesmrec]

@davivel, the behaviour right now is setting the same message in both banned uploads due to firewall rule and lack of permissions. Upload not allowed. This is the same behaviour as before but with a different message.

[davivel]

Too easy to be true; checking.

[davivel]

Now it should be fixed; @jesmrec , please, test again.

[jesmrec]

Setting some rules like:

• Client device is ...
• User groups is ...
• Request time between ...

and trying to download a file, the error message is 'Cannot establish connection'. This message does not show what is really happening. Could it be improved?

@davivel @nasli

[rperezb]

fyi there is a blocking issue https://github.com/owncloud/firewall/issues/266

[davivel]

Updated message for downloads.

[jesmrec]

Bug fixed. Approved, but pending the server issue to be fixed.

As tech debt, the uploads view should be refactored to set retries in case they are needed (like in the case of lack of quota)

CC @nasli @davivel

[davivel]

@jesmrec , could you open a new issue for the retries?

Thanks