[fix/shortcut-save-file]

[hosy]

Description

File could to be saved, when trying to save a file with Shortcuts and it already exists

Related Issue

#622

How Has This Been Tested?

Check Issue #622

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[jesmrec]

The fix directly overwrites the existing file in the same path. This behaviour can be dangerous and lead to data loss. Should it be better to create a new file with the incremental number (same as uploading twice the same file)?

[hosy]

@jesmrec yes, this is exactly what it should do, because as I user I want to write data to the same file.
If you do not agree, we can add a parameter Overwrite if already exists with YES/NO, to prevent overwriting, if it should not. What do you think?

[jesmrec]

It sounds good. So, the user can decide to overwrite the latest version or keep it by creating a new one.

[hosy]

@jesmrec new parameter was added, please check again

[jesmrec]

Works properly when Overwrite existing file is enabled and disabled. And it is good to have that this is disabled by default, so the user has to decide explicitly if the file will be overwritten.

Approved.