Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated README.MD #599

Merged
merged 5 commits into from
Jan 21, 2020
Merged

Updated README.MD #599

merged 5 commits into from
Jan 21, 2020

Conversation

hosy
Copy link
Collaborator

@hosy hosy commented Jan 21, 2020

Description

This PR is updating the README.MD file for a better marketing on Github, because the readme file is shown the user as entry page.

Motivation and Context

  • Better Marketing for our iOS app
  • Show contributors relevant informations
  • Show features of our app

This PR will also add the fastlane/screenshots/ folder to git, because with this we have the latest AppStore screenshots as backup. Furthermore the latest screenshots are used in the readme file.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@hosy
- updated readme file
00ffe81 
- removed fastlane screenshots folder from git ignore, to have the latest screenshots into github
@hosy hosy requested review from michaelstingl and jesmrec January 21, 2020 10:45
@hosy hosy self-assigned this Jan 21, 2020
@hosy hosy added this to the 1.3.0-Current milestone Jan 21, 2020
@hosy
Copy link
Collaborator Author

hosy commented Jan 21, 2020

@michaelstingl please have a look, if you want to use this new readme file for our repository:
https://github.com/owncloud/ios-app/blob/github-readme-update/README.md

jesmrec
jesmrec reviewed Jan 21, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
michaelstingl
michaelstingl approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@michaelstingl michaelstingl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice improvements 👍

@hosy hosy requested a review from jesmrec January 21, 2020 12:20
@jesmrec jesmrec added the Approved by QA Approved by QA label Jan 21, 2020
@hosy hosy merged commit 93cdae4 into milestone/1.3 Jan 21, 2020
@delete-merged-branch delete-merged-branch bot deleted the github-readme-update branch January 21, 2020 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jesmrec jesmrec jesmrec approved these changes

@michaelstingl michaelstingl michaelstingl approved these changes

Assignees

@hosy hosy

Labels
Approved by QA Approved by QA
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@hosy @michaelstingl @jesmrec