[feature/log-info] Log device, version and locale info #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y log file using new SDK protocol - Show SDK commit hash in Settings
|
|
hosy
added a commit
that referenced
this pull request
Aug 5, 2019
* [fix/auth] Fix issues in handling and improve handling of auth errors (#459) * - Authentication error produce only a single alert now - Added special handling and messages for - Account disabled server side - Authentication data missing for bookmark (f.ex. after a device restore from an unencrypted backup) - Fix retain cycle leading to zombie OCCore when hitting Edit * - If auth fails, replace "Edit" with "Sign in" in the alert and attempt login if updating the bookmark succeeded * - Move code for editing bookmark and reconnecting to a new ClientRootViewControllerAuthenticationDelegate, so that functionality isn't hardwired to ServerListTableViewController and BookmarkViewController * - Present different error message for auth failures if the auth method is token based * - Extend handling of authorization errors to errors re-packaged as OCIssues * - Enhance UX when editing credentials-based bookmarks following an authorization failure - Improve handling of .authenticationData reset: now only a soft-reset of the editable copy * - Update ios-sdk reference to ios-sdk master with fix/auth merged in * fixed missing semicolon * fixed UI tests * [fix/0xdead10cc] Fix dead10cc forced termination (#462) * - Fix `0xdead10cc` crash by switching SQLite journal mode from DELETE to WAL * - Switch SDK to release/1.0.4 branch * changed app version to 1.0.4 * Version Bump to 127 * [feature/log-info] Log device, version and locale info (#468) * - Log device, version and locale information at the beginning of every log file using new SDK protocol - Show SDK commit hash in Settings * using correct release SDK * Added changelog for version 1.0.4 * Version Bump to 128 * - Update to SDK with fixes for finding (1) in #466 * use tagged and signed master SDK 1.0.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merge #446 into Release 1.0.4 branch
Related Issue
Motivation and Context
#444
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: