Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature/http-warning] Warn of plain HTTP URLs during setup #328

Closed
wants to merge 1 commit into from

Conversation

felix-schwarz
Copy link
Contributor

@felix-schwarz felix-schwarz commented Mar 22, 2019

Description

Introduces a new warning when trying to setup an account with a plain HTTP URL (via updated SDK and a new generic issue type).

Related Issue

#267 ( @michaelstingl 's comment: #267 (comment))

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

- Fixed SwiftLint warnings
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented Mar 22, 2019

Codecov Report

Merging #328 into master will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #328   +/-   ##
=======================================
  Coverage   29.57%   29.57%           
=======================================
  Files         229      229           
  Lines       15521    15521           
=======================================
  Hits         4590     4590           
  Misses      10931    10931
Impacted Files Coverage Δ
ownCloud/Client/PhotoSelectionViewCell.swift 0% <ø> (ø) ⬆️
ownCloud/Bookmarks/BookmarkViewController.swift 81.92% <ø> (ø) ⬆️
ownCloud/Client/ClientQueryViewController.swift 34.1% <0%> (ø) ⬆️
ownCloud/SDK Extensions/OCIssue+Extension.swift 57.89% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f045ed...362d08e. Read the comment docs.

@hosy hosy self-requested a review March 23, 2019 06:19
@michaelstingl michaelstingl added the p2-high Escalation, on top of current planning, release blocker label Mar 29, 2019
@michaelstingl michaelstingl added this to the 1.0.0-Current milestone Mar 29, 2019
@felix-schwarz
Copy link
Contributor Author

felix-schwarz commented Apr 1, 2019

Changes were folded into #325, so this PR is now redundant and can be closed.

@felix-schwarz felix-schwarz deleted the feature/http-warning branch May 29, 2019 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-high Escalation, on top of current planning, release blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants