[milestone/12.0.3] Milestone 12.0.3 #1236

felix-schwarz · 2023-06-28T10:07:52Z

Description

Implements these changes:

new: adds mtime metadata to TUS uploads
new: CSS gains variable support (via experimental/branding)
improved: App Provider fixes / feature detection
fix: update connection name in sidebar after it has been edited
fix: avoid unwanted Auto Layout collapse of select button in location picker / BottomButtonBar
fix: FileProvider slowness and hangs
fix: FileProvider crash when being passed a nil item identifier by iOS
updated translations via Translation sync #1269

Related Issues

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
Added an issue with details about all relevant changes in the iOS documentation repository.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.
Added changelog files for the fixed issues in folder changelog/unreleased

…supportsCreateDocument - AccountConnection: create Open with actions dependant on OCAppProvider.supportsCreateDocument - OpenInWebAppAction: - introduce new "auto" mode that uses the best available method - or shows an error - limit size of icons to a maximum of 32x32 points - update SDK for new feature detection capabilities

CLAassistant · 2023-06-28T10:07:59Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 4 committers have signed the CLA.

✅ hosy
✅ michaelstingl
❌ felix-schwarz
❌ Michael Stingl

Michael Stingl seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

- add missing errorHandler calls to FileProviderContentEnumerator - add last resort enumeration completion call to FileProviderEnumeratorObserver.dealloc - add additional debug logging

…pace for the logo image

Co-authored-by: Michael Stingl <[email protected]>

* Remove old PLIST examples * move ownCloud.online theme + assets * move EMM assets * Adjust Fastfile for moved themes + assets * updated to Xcode 14.3 * move all app resources to the correct place in one copy command * updated to 14.3.1 --------- Co-authored-by: Michael Stingl <[email protected]> Co-authored-by: Matthias Hühne <[email protected]>

- added accessibility label to the logo image

…erprise#5889)

- add support for RGBA hex values to CSS

…screen background (#1264) * - add background image to welcome screen - add support for RGBA hex values to CSS * Assets.xcassets/AppIcon.appiconset generated with fastlane * align icon name with branding --------- Co-authored-by: Felix Schwarz <[email protected]> Co-authored-by: Michael Stingl <[email protected]>

…cords for colors, incl. a set of system colors - ThemeCollection: add system colors (f.ex. UIColor.systemBlue as `os.color.blue`) and theme base colors (as `theme.color.light` and `theme.color.dark`) to CSS object

…branding

…o dark

- add permanent logo branding to top of the view - make branding elements use same CSS selectors as welcome screen - ComposedMessageView: make CSS selectors extension public - RoundCornerBackgroundView: add new .fillImage property that allows filling the view with an image with "scaleAspectFill" contentMode

…nded builds

michaelstingl · 2023-08-28T07:39:07Z

In addition to the comments above, the login view does not look like nice in iOS17. Fix here or in following releases?

Uh. not nice. Worse then I expected. I thought color-wise, everything is better in iOS 17… 🤔

jesmrec · 2023-08-28T10:49:37Z

@felix-schwarz was this fix included in the release branch? It is closed but i can reproduce the problem in b5391b8 . Changes in the name are not applied till apps is reopened.

felix-schwarz · 2023-08-28T13:48:18Z

@felix-schwarz was this fix included in the release branch? It is closed but i can reproduce the problem in b5391b8 . Changes in the name are not applied till apps is reopened.

It was merged into milestone/12.0.3 and closed after @michaelstingl could no longer reproduce the issue after that. I also just tried to reproduce the issue with the latest build but couldn't. Can you share a video?

…s that are also subject to NSObject.applyThemeCollection() calls

…tup view into own view controller - InitialSetupViewController: implement status bar style support for consistent status bar colors also pre-iOS 17

felix-schwarz · 2023-08-28T15:43:02Z

@jesmrec @michaelstingl All color issues (including status bar and iOS 17) should be fixed as of the latest commit / build 280.

michaelstingl · 2023-08-28T16:33:52Z

Yeah, rock-solid in iOS 16 + 17, following system dark + light mode ✅

jesmrec · 2023-08-29T05:35:02Z

It was merged into milestone/12.0.3 and closed after @michaelstingl could no longer reproduce the issue after that. I also just tried to reproduce the issue with the latest build but couldn't. Can you share a video?

@felix-schwarz here it is:

RPReplay_Final1693287049.MP4

jesmrec · 2023-08-29T08:23:46Z

@jesmrec @michaelstingl All color issues (including status bar and iOS 17) should be fixed as of the latest commit / build 280.

fixed in a455ce1dc.

Still dark login view, but it will be expected in 12.0.3

felix-schwarz · 2023-08-29T08:56:42Z

@jesmrec Thanks for the video. I can now reproduce it on an iPhone when the bookmark did not have a name previously. Looking into it.

jesmrec · 2023-08-29T09:00:50Z

@felix-schwarz also, detected this glitch in an iPhoneX. I guess it's caused because the screen width:

Settings > Media Upload > Auto Upload Photos -> switch on

Button to select destination is not correct. Curiously, just happens with Auto Upload Photos and not with Videos

iPhoneX 16.5
a455ce1d

felix-schwarz · 2023-08-29T12:32:13Z

@jesmrec The rename issue is fixed as of 1932993.

…e promptText above the buttons in any but regular horizontal class size and stretching the buttons to fill the space beneath it

felix-schwarz · 2023-08-29T13:04:38Z

@jesmrec The layout glitch is also fixed now. The button bar layout now adjusts to the horizontal size class and puts the prompt text above the buttons if the size class is not regular:

…SectionSource with item version tracking

jesmrec · 2023-08-29T15:42:01Z

Everything fixed

jesmrec · 2023-08-29T15:47:13Z

QA

This is a bugfixing release, so no complete regression test is required

Changelog

Open in web (oC10) https://github.com/owncloud/enterprise/issues/5747
Header X-OC-mtime [BUG] TUS -H 'Upload-Metadata: mtime missing #1227
Bookmark name [BUG] Connection name doesn't change immediately #1254
"Copy here” in spaces https://github.com/owncloud/enterprise/issues/5889
Files app issues -> not reproducible on my side. Fixes confirmed by users

Smoke test

Server version: 10.13.0 && 4.0.0
Device & iOS version: iPhoneX, iOS 16.5.1 (REAL), iPhone 14, iOS 16.5 (SIM), iPhoneXR 17.0 (REAL)

Test Case	Steps	Expected Result	Result	Related Comment
Login Basic	Login in an oC10 server, typing correct credentials	Access to account	Passed	AUTO
New folder	Open '+' and select to create a new folder with correct name	The folder is created with the correct name	Passed	AUTO
Rename	1. Select an item by clicking on 3-dot-button 2. Select Rename and type new correct name	Item is renamed with the new name	Passed	AUTO
Move	1. Select an item by clicking on 3-dot-button 2. Select Move, and a new location	Folder is moved to the specified location	Passed	AUTO
Copy	1. Select a folder by clicking on 3-dot-button 2. Select Copy, and a location to copy to (including space)	The folder and all its content is copied to the location, and also remains in the original	Passed	AUTO
Duplicate	1. Select a folder by clicking on 3-dot-button 2. Select Duplicate	The folder and all its content is duplicated in the current location, with the name adding `2`	Passed	AUTO
Delete	1. Select a folder by clicking on 3-dot-button 2. Select Delete and submit deletion	Item deleted	Passed	AUTO
Upload Files	Select many files from File apps to upload to oC	Files are uploaded	Passed	AUTO
Upload Albums	Select 300 images and videos from Albums to upload to oC	Images and videos are uploaded	Passed
Download	Tap to download a file	The file is downloaded and previewed	Passed
Av Offline	1. Select a folder by clicking on 3-dot-button 2. Select set as Av Offline file	The file is downloaded and set as Av Offline	Passed
Av Offline folder	1. Select a folder with subfolders inside by clicking on 3-dot-button 2. Select Av. offline 3. Add new content to the folder	2. The folder and all its content is downloaded and set as Av Offline 3. New content is available offline	Passed
Share with user	1. Select file and folder by clicking on 3-dot-button 2. Select Share and add new recipient 3. Recipient accepts the share	Both are correctly shared and visible by the recipient in Shares space	Passed	AUTO
Link	Create a link over a file and a folder	Links are correctly created	Passed	AUTO
Spaces	1. In web, create some spaces that are visible for the user	List of spaces is visible in the account	Passed	AUTO
Files App	1. Add several accounts 2. Open Files app	All accounts are correctly listed and are browsable	Passed

Autom test report vs oCIS

Autom test report vs oC10

Upgrade test

12.0.2 -> 12.0.3 with oC10 (basic), oC10 (OAuth2), oCIS (OIDC) ✅

Approved on my side.

Approved commits:

app: 40dfc92
sdk: 740b63e

Devices:

iPhoneX 16.6
iPhoneXR 17.0 (just basic checks)

Xcode version: 14.3.1 (14E300c)

felix-schwarz and others added 28 commits July 3, 2023 12:33

- add support for TUS upload mtime metadata header (fixing #1227)

4b9b483

- FileProviderExtension: add additional debug output for enumerator

4cee115

FileProvider:

ce2ab28

- add missing errorHandler calls to FileProviderContentEnumerator - add last resort enumeration completion call to FileProviderEnumeratorObserver.dealloc - add additional debug logging

- FIleProviderContentEnumerator: add/refine more debug logging

bc1327a

- bump version to 12.0.3 and build number to 271

59736f7

removed the logo label from the sidebar navigation bar to have more s…

5313248

…pace for the logo image

- update SDK to fix owncloud/enterprise#5811

9cb4d8c

- fix #1254

a95bb44

Example JSON + README (#1255)

e0d8c18

Co-authored-by: Michael Stingl <[email protected]>

- FileProvider: fix enumerator queue completion slowdown/blocking

5d54b5d

- show vendor label in the sidebar if app is unbranded

e14352c

- added accessibility label to the logo image

- FileProvider cleanup and additional debug logging

0571ec7

- BottomButtonBar: avoid collapse of selectButton (fixes owncloud/ent…

9a3e5ef

…erprise#5889)

- add background image to welcome screen

fed83fd

- add support for RGBA hex values to CSS

- change welcome screen background default color from dark to bright

b4c5320

- BookmarkViewController: add .bookmarkEditor CSS selector

3e7198b

Merge branch 'fix/sidebar-logo' into experimental/branding

e596ab7

- ThemeCSS: add support for $cssSelector.cssProperty

3346666

- change welcome screen background default color from dark to bright

abe25cb

Assets.xcassets/AppIcon.appiconset generated with fastlane

1ea7a36

rename vanilla appiconset again for fastlane changes

fa5b296

Merge branch 'experimental/branding-css-syscolors' into experimental/…

f0e779b

…branding

Vanilla: change welcome screen background default color from bright t…

5c7db31

…o dark

- BookmarkViewController: remove table view background image from bra…

a9ca511

…nded builds

felix-schwarz added 3 commits August 28, 2023 16:12

- NSObject+ThemeApplication: fix wrong label colors for ThemeCSSLabel…

069feb8

…s that are also subject to NSObject.applyThemeCollection() calls

- AppRootViewController + InitialSetupViewController: move initial se…

d511896

…tup view into own view controller - InitialSetupViewController: implement status bar style support for consistent status bar colors also pre-iOS 17

- fix iOS 17 initial setup color issue

a455ce1

felix-schwarz added 2 commits August 29, 2023 11:38

- address owncloud/core#40953 (comment) via SDK update

9662483

- fix: rename of a bookmark is not always reflected in the account list

1932993

- BottomButtonBar: adapt layout dynamically to size class, placing th…

bf5a832

…e promptText above the buttons in any but regular horizontal class size and stretching the buttons to fill the space beneath it

felix-schwarz added 2 commits August 29, 2023 16:25

- ClientSidebarViewController: properly initialize accountsController…

72e9873

…SectionSource with item version tracking

- fix SwiftLint warnings

40dfc92

felix-schwarz requested review from hosy and jesmrec September 4, 2023 07:37

jesmrec approved these changes Sep 4, 2023

View reviewed changes

hosy approved these changes Sep 4, 2023

View reviewed changes

hosy and others added 3 commits September 5, 2023 13:30

added missing Calens changelog files

f646363

added latest app store release notes

cec93e9

Calens changelog updated

4d00e27

hosy merged commit 1107434 into master Sep 5, 2023

delete-merged-branch bot deleted the milestone/12.0.3 branch September 5, 2023 11:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[milestone/12.0.3] Milestone 12.0.3 #1236

[milestone/12.0.3] Milestone 12.0.3 #1236

felix-schwarz commented Jun 28, 2023 •

edited by hosy

Loading

CLAassistant commented Jun 28, 2023 •

edited

Loading

michaelstingl commented Aug 28, 2023

jesmrec commented Aug 28, 2023

felix-schwarz commented Aug 28, 2023

felix-schwarz commented Aug 28, 2023 •

edited

Loading

michaelstingl commented Aug 28, 2023

jesmrec commented Aug 29, 2023

jesmrec commented Aug 29, 2023

felix-schwarz commented Aug 29, 2023

jesmrec commented Aug 29, 2023

felix-schwarz commented Aug 29, 2023

felix-schwarz commented Aug 29, 2023 •

edited

Loading

jesmrec commented Aug 29, 2023

jesmrec commented Aug 29, 2023 •

edited

Loading

[milestone/12.0.3] Milestone 12.0.3 #1236

[milestone/12.0.3] Milestone 12.0.3 #1236

Conversation

felix-schwarz commented Jun 28, 2023 • edited by hosy Loading

Description

Related Issues

Screenshots (if appropriate):

Types of changes

Checklist:

CLAassistant commented Jun 28, 2023 • edited Loading

michaelstingl commented Aug 28, 2023

jesmrec commented Aug 28, 2023

felix-schwarz commented Aug 28, 2023

felix-schwarz commented Aug 28, 2023 • edited Loading

michaelstingl commented Aug 28, 2023

jesmrec commented Aug 29, 2023

jesmrec commented Aug 29, 2023

felix-schwarz commented Aug 29, 2023

jesmrec commented Aug 29, 2023

felix-schwarz commented Aug 29, 2023

felix-schwarz commented Aug 29, 2023 • edited Loading

jesmrec commented Aug 29, 2023

jesmrec commented Aug 29, 2023 • edited Loading

QA

Changelog

Smoke test

Upgrade test

felix-schwarz commented Jun 28, 2023 •

edited by hosy

Loading

CLAassistant commented Jun 28, 2023 •

edited

Loading

felix-schwarz commented Aug 28, 2023 •

edited

Loading

felix-schwarz commented Aug 29, 2023 •

edited

Loading

jesmrec commented Aug 29, 2023 •

edited

Loading