Feature/more #106
Merged
Feature/more #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #106 +/- ##
==========================================
- Coverage 27.98% 27.17% -0.82%
==========================================
Files 64 63 -1
Lines 5906 5741 -165
==========================================
- Hits 1653 1560 -93
+ Misses 4253 4181 -72
Continue to review full report at Codecov.
|
|
@pablocarmu why is the file name twice at the right of the thumbnail:
|
|
View in landscape with iPhone X:
the |
|
I think we discussed this on Friday: Maybe keep same margin from left as in the file list. |
pablocarmu
force-pushed
the
feature/more
branch
from
c034a6d to
286f1d7
Compare
added 5 commits
August 22, 2018 09:20
…sign guidelines described in #82 - Created new init methods in StaticTableViewRow and StaticTableViewSection to support NSAttributedString as titles. - Created new UIPresentationController called CardPresentationController to support the presentation of a view controller in a "card" way. - Coded support for NSAttributedString in ThemeTableViewCell.
- Coded the size of the item as detail label in the more header.
- Coded the rename feature using the more view.
- Now the detail label in the MoreHeaderView shows the last modified date of an OCItem.
pablocarmu
force-pushed
the
feature/more
branch
from
001d506 to
c24441d
Compare
|
All stuff fixed. OK from side |
jesmrec
approved these changes
Aug 22, 2018
|
Started reviewing and, using the default theme, I'm getting this: Can you reproduce that? |
…ntQueryViewController - Figured out card-style scrolling: - until the card is fully "open": all pan gestures move the card - once the card is fully "open": - pans in UIScrollView upwards scroll the scrollView up - pans in UIScrollView downwards - scroll the scrollView down if its position is not already at the top - move the card if the scrollView's position is already at the top
|
|
…n't be extended beyond the maximum size of the content - Make MoreStaticTableViewController adopt dynamic sizing/auto layout - Fix formatting - Fix SwiftLint warnings - Add missing license texts
…dPanGestureRecognizer and dimmingViewGestureRecognizer types - add overStretchView that is attached below the presentedView - make sure containerViewWillLayoutSubviews isn't interferring with animations / user drags - considering that the card won't permanently extend beyond the size of the card, default the cardPosition to .open to show as much of the card as possible
- Make taps on the drag handle dismiss the card - Add support for iPhone X safe areas to CardPresentationController - CardPresentationController dynamically makes MoreViewController disable scrolling if it fits entirely on screen - unified dismiss code - added convenience method to UIViewController to quickly present a view controller as a card - cleaned up static table view code and made the moreViewController use "buttonWithAction" - added support for non-opaque buttons to StaticTableViewRow - cleaned up MoreViewController constraints and fixed an exception/warning during rotation - fixed thumbnail size in MoreViewHeader - rewrote MoreViewHandler constraint code - Fix indentations in various places
…ntroller - ClientQueryViewController gains new methods for folder creation, rename and delete - added titles to "New folder" and "Rename" actions - fix missing spacing of sortbar when rotating in iPhone X and using in landscape - improved text in alerts - remove NSAttributedStringKey extension as its no longer needed
felix-schwarz
approved these changes
Aug 31, 2018
…taticTableViewSection to MoreStaticTableViewSection, as the properties are only used by MoreStaticTableViewController.
|
Approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes a new view for actions instead of swipes.
Related Issue
#82
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: