[RELEASE] 1.3

[hosy]

Release a new version

TASKS:

Git & Code

• [GIT] Create branch release/[major].[minor].[patch] (freeze the code)
• [DEV] Update APP_SHORT_VERSION [major].[minor].[patch] in ownCloud.xcodeproj/project.pbxproj
• [TRFX] Update translations from transifex branch.
• [DIS] Update changelog
• [DEV] Update In-App Release Notes (changelog) in ownCloud/Release Notes/ReleaseNotes.plist
• [QA] Design Test plan
• [QA] Regression Test plan
• [DOC] Update user manual with the new functionalities
• [DOC] Update owncloud.org/download version numbers (notify #wordpress)
• [GIT] Merge branch release/[major].[minor].[patch] in master
• [GIT] Create tag and sign it [major].[minor].[patch]
• [GIT] Add the new release on GitHub ios-app

If it is required to update the iOS-SDK version:

• [GIT] Create branch library release/[major].[minor].[patch](freeze the code)
• [mail] inform #marketing about the new release.
• [DIS] Update README.md (version number, third party, supported versions of iOS, Xcode)
• [DIS] Update changelog
• [GIT] Merge branch release/[major].[minor].[patch] in master
• [GIT] Create tag and sign it [major].[minor].[patch]
• [GIT] Add the new release on GitHub ios-sdk

If it is required to update third party:

• [DIS] Update THIRD_PARTY.txt

App Store

• [DIS] App Store Connect: Create a new version following the [major].[minor].[patch]
• [DIS] App Store Connect: Trigger Fastlane screenshots generation and upload
• [DIS] Upload the binary to the App Store
• [DIS] App Store Connect: Trigger release (manually)
• [DIS] App Store Connect: Decide reset of iOS summary rating (Default: keep)
• [DIS] App Store Connect: Update description if necessary (coordinated with #marketing)
• [DIS] App Store Connect: Update changelogs
• [DIS] App Store Connect: Submit for review

QA

Test plan:

https://github.com/owncloud/QA/blob/master/Mobile/iOS-app/Version%201.3.0/Regression.md

BUGS & IMPROVEMENTS:

• (1) Icons missed in What's new [RELEASE] 1.3 #598 (comment) [FIXED]
• (2) iOS13 features in iOS12 What's new [RELEASE] 1.3 #598 (comment) [WONT FIX]
• (3) Camera uploads stucked from archived ipa [RELEASE] 1.3 #598 (comment) [FIXED]
• (4) New document from MSOffice [RELEASE] 1.3 #598 (comment)

[jesmrec]

(1) [FIXED]

1. Install 1.2.1
2. Set Classic/Light theme
3. Upgrade to 1.3.0

Current: What's new is displayed but icons are missed. Also, message to rate the app is missed
Expected: What's new is correct

Dark	Classic	Light

[jesmrec]

(2) [wont fix]

Users with iOS12 will see in the What's new all the features that will not be available in such version (scanner, shortcuts, markup). Should them be hidden depending on the version? (if feasible). Or clarifying that are only available for iOS13 (as in the description of Shortcuts)

[jesmrec]

(3) [FIXED]

Camera uploads are not behaving in the same way, depending whether the app is installed from XCode or from an archived ipa.

In case of an archived ipa, the pics are stucked in status view as Media Import

Here it is the difference:

From XCode	From archived ipa

both gifs were taken with the same commit: 8ebbcfb and an iOS13 device.

[jesmrec]

(4) [WONT FIX - word bug]

1. Open Word app
2. Create a new document
3. Save to oC

Current: zero bytes document

Expected: correct document

Log file (name of the word file: DocumentTest.docx):

ownCloud_11_Feb_2020_at_15_44_42.log.txt

iOS13 iPhone XR
commit: 8ebbcfb

probably related with https://github.com/owncloud/enterprise/issues/3803#issue-557337146

[hosy]

@jesmrec (1) is fixed
(2) I think this is not a problem, because iOS 13 features will be named in the release notes, that this depends on the iOS version. On the App Store release notes all features are mentioned too.

[jesmrec]

(1) fixed

[hosy]

@jesmrec (3) disabled optimization levels again in SDK to prevent Xcode bug. Please check this problem again, with the latest commit 2860441

[jesmrec]

thanks for checking! (3) is fixed

[felix-schwarz]

Regarding (4) @jesmrec @hosy:

Here's what I found out:

Retrospective

The last time we had a zero-sized Word document issue, Word saved files this way:

1. Word tells the FP to import the new document, but only provides a 0-byte file
2. Word actually saves file
3. Word tells the FP that there's an update to the document (now with actual contents)

Back then, 3) triggered a race-condition, which has since been fixed.

Today

Today, Word behaves differently:

• Word still tells the FP to import the new document, but only provides a 0-byte file
• it no longer follows up with actually saving the file and notifying the FP about a change
• once the user closes the document, Word actually saves the file and notifies the FP that there's an update to the document
• at that point, the file is saved to the server as expected

Reproducability

Saving a file to iCloud Drive also produces a zero-sized file until closing the document:

Conclusion

This does not appear to be a bug in the File Provider. Instead, Word simply doesn't provide any file contents to the FileProvider until the user closes the document.

Microsoft likely tries to avoid unnecessary traffic by not saving copies until the user actually is finished working on a file. While I'm not sure that's a good way to achieve that, I'm pretty sure we can do nothing about it. 😕

[michaelstingl]

Microsoft likely tries to avoid unnecessary traffic by not saving copies until the user actually is finished working on a file. While I'm not sure that's a good way to achieve that, I'm pretty sure we can do nothing about it. 😕

Word settings look they're doing "Autosave". I'd expect they actually save data to the document during editing, not only when you close the document 🤔 . Does the 0-byte file already has a "real" file name? Or is it a temporary name with "~" or something?

[felix-schwarz]

It has the real filename. What's odd is that even "Save a copy" in Word sends a zero-sized file to the File Provider and also only provides actual content when closing the document.

[felix-schwarz]

As far as Auto-Save is concerned, Microsoft writes "Änderungen werden automatisch in iPhone gespeichert" (sic), which is either really bad wording - or a hint that auto-save only happens locally.

[michaelstingl]

Word bugs from my pov

[felix-schwarz]

Likewise, turning off Auto-Save and hitting Save directly also doesn't send any command to the File Provider or seem to actually save the file.

The only thing that it does send (and we don't currently support due to lack of server-side support), however, is to update the "last used" date. Right now, we return a "not supported" error for that, so I considered that Word might not update the file because of that. However, even returning "success" here wouldn't make Word notify the FP about changes or save the file. And at the time the "set last used date" command was called, the file on disk was also still zero-sized.

[felix-schwarz]

Word bugs from my pov

Yep. I think so, too.

[jesmrec]

From my side, tests are passed

[hosy]

@settermjd we have a lot of new features in version 1.3.0 which needs documentation. If you need an introduction, please ping me. Thank you!

[cdamken]

@felix-schwarz @michaelstingl if the autosave is disabled works in the proper way?

if that is the case: Is there any way to detect it? we could send some warnings in the app? or in a readme?

[felix-schwarz]

@cdamken Word shows the same behaviour when disabling autosave and tapping "Save": the actual file is only saved back to the cloud/File Provider when the user closes the document.

Unfortunately, there's nothing we can do about it from our side. It's a Word implementation detail that equally applies regardless of which File Provider people use.

Since iOS apps don't have access to the list of running processes or access to the sandboxes of other apps, it's not possible to detect and warn users about this Word behaviour.

[michaelstingl]

@jesmrec @felix-schwarz I’ve got a report, that MS Word for iOS update 2.3.4 from Februar, 10th, fixed the problem. Thanks @cdamken for the feedback.