Version 1.0.0 #237
Comments
michaelstingl
added
the
p2-high
(1)
Current: ugly error is displayed:
Expected: User is asked for approval NOTE: this only happens the first time. to reproduce, important to install from scratch Devices: iPhoneX and iPadPro v12 |
(2)To reproduce this, replicate the steps in (1) but adding two accounts in the same server
Current: Devices: iPhoneX and iPadPro v12 |
(3) [FIXED]Thumbnails overplace the cell size (regression):
|
(4) [FIXED]
Current: non-readable error:
Expected: readable error Devices: iPhoneX and iPadPro v12 |
|
Fixed (3) as of 361b152
|
|
Fixed (4) as of owncloud/ios-sdk@5ca643b and 133a2f8:
|
|
(3) and (4) fixed |
(5) [FIXED]
Current: file os downloaded, but download spinner remains. By tapping on it, it stops and the file is downloaded Devices: iPhoneX v12 NOTE: this should not be a release blocker. in case the fix is tricky, we can delay or open in a separate issue to be scheduled in the near future. |
|
Fixed issue (1) and (2) via owncloud/ios-sdk@88ae30b and 3998925 @jesmrec |
(6) [FIXED]
Current: The following error is displayed:
even when the file is correctly uploaded. Finally, everything is uploaded but there are many files with spinner. By tapping, the spinner is gone:
Expected: no error, files keep uploading till they finish. At the end, all spinners are gone. Devices: iPhoneX and iPadPro v12 |
(7) [FIXED]
Current: Final number of files in the folder is less than 200 (quota is enough) Devices: iPhoneX v12 |
|
(1) and (2) fixed |
(8) [FIXED]
Current: Error displayed is not accurate. is it posible to make it more user-readable or is it a Files app issue?:
iPhoneX v12 basic auth account |
(9) [FIXED]
|
|
(9) fixed |
(10) [WONT FIX -> Apple issue]Duplicate a folder in Files App Current: it tries to create the new folder with the same name as the source, so it returns an error iPhoneX v12, iPadAir v12 |
(11)Improvement: In Files App, if you delete a folder, you are asked for confirmation. This is the regular behaviour for destructive actions. If you delete a file, the file is deleted with no confirmation. Is this a Files App issue, or can be addressed as improvement for the app itself? |
|
Fixed (5) as of 72774d0. |
(46)When a file is downloaded, the intermediate download view is displayed, and then the file. Such view is only used when offline mode is set. It can be avoided if the download progress is tracked with the spinner in the files view.
iPhone 6Plus v12.2 |
|
@jesmrec @felix-schwarz (45): file name is |
|
@jesmrec Regarding (46) I think logical would be to immediately open the file viewer and show download progress there and not to wait in the list view until the file is downloaded. |
|
@hosy Re (44): This is another iOS bug. Here's what I found: When I save the file the first time, it works as expected: When I save the file the second time, our FileProvider correctly returns a collision: That prompts iOS to bring up this alert:
If I pick "Keep both", iOS picks a different name and re-attempts the upload (which succeeds): If I pick "Replace", iOS does not attempt another Instead, it attempts to Noteworthy in this context is that The workaround was to add an implementation for the Fortunately the Files app respects With the workaround in place, replacing now works: While at it, I've also added log messages to the remaining two, unimplemented actions, so that we get log visibility if they're used and the fact they're not implemented has side effects like such an error. That said, the issue is fixed as of b4676e1. |
i guess it was before, but the behaviour was changed. Actually, you can download several files at the time by staying in the files view, and finally, the latest selected was the opened. We should agree something here. about (45), anything to do, or we have to accept the behaviour as the expected. Thanks. |
I think if user taps an item, he would expect the detail view to open immediately.. this is what my UX gut feeling says.. Also what you have mentioned regarding downloading files and then the last one being displayed is somewhat confusing. @felix-schwarz @hosy @michaelstingl opinions? |
|
@jesmrec Re (45): strange that iOS returns same name for multiple photo files but I have no idea about photo library layout on the file system.. I mean we probably could do something about it like change the file name on the fly when uploading similarly to duplicate logic or sth. like that. |
|
@mneuwert Re (46), I agree, the download view should only be shown in case the download is started from the viewer (f.ex. when opening a file that has no local copy while offline, then coming online). Regarding tapping multiple items, I added that intentionally to avoid confusion: Image a user who wants to download a couple of large files, tapping them in quick succession - while the download of the items tapped earlier hasn't yet finished. I don't think it'd be good to then push a viewer for each item as they finish downloading. The user would view file A, then file B finishes downloading and file B's viewer gets pushed over it. Repeat for file C, D, E… Since the user has no control over the time the downloads finish for each file, the user would be interrupted by new viewers opening on top of the file the user currently views / interacts with. IIRC Apple's Files app takes this approach of viewing only the last tapped item, too. Browsers also do it that way: if a user clicks a link on a website, but realizes he/she clicked the wrong link before the next page finishes loading, clicking another link will take the user to that (last clicked) link's page instead. |
|
@felix-schwarz Re (46) I didn't intend to push multiple viewers when user taps multiple items.. Just open viewer immediately for the selected file and show download view. For the downloading multiple files in quick succession, we could make cloud icon tappable, but I am fine with the current implementation when the download view won't be shown for the already downloaded item |
|
@mneuwert Re (46): I'd be ok with tappable cloud icon, too, but that'd require a design change as the cloud icon isn't sufficiently big to be a reliable tap target.
Me too. Taking care of that. |
…re already downloaded (issue (46) in #237) - Fix bug in PDFViewerViewController where CoreGraphics would throw an error when using pdfView with zero size (before properly laying it out)
|
Addressed (46) as of 14dbecb. |
|
(46) -> fixed (47)After (46) fix , the non-openable files prompt the download progress bar in the "details" view:
Progress bar and cancel button must be hidden. |
- Fix (47) "the non-openable files prompt the download progress bar in the "details" view" in #237
|
(48) If a server has a complex folder structure, the |
|
(47) -> fixed |
* hide beta warning * [Bugfix 1.0.0] Fixed an issue with drag to action not working for some actions * - Fix issue (3) "Oversized thumbnails" - Fix separator insets in item list * - Produce an appropriate error when an upload fails due to insufficient space left on the server (fix (4)) * - Fixing issue (1) and (2) via SDK update * Version Bump to 114 * - disable table cell selection - fixed long status messages, while setting dynamically numbers of lines * Version Bump to 115 * - Fixed (5) where the progress of a file that completed download in the background was shown incorrectly * - Improve progress updates and representation in ClientItemCell * - Fix: indicate activity during last phase of setting up a new bookmark and whenever editing a bookmark and saving it (previously UI seemed stuck for a couple of seconds) * - Added NSError+MessageResolution that resolves the localized description for OCErrors so they are included when serialized, so they become visible in the Files app, too - Fixing issue (8) in #237 * Implemented improvement (13) * - Fix newly introduced potential crash bug in renameItem FP method - Remove trash method and permission flag for items in FP, so "Delete Now" is the only option and Files app shows a warning - Fixing (11) in #237 * - Rename uploadsBarButton to plusBarButton in ClientQueryViewController - Add new action extension location .plusButton - Add Action extensions support to provide UIAlertAction objects - Add .plusButton location to CreateFolder action - Extend the ClientQueryViewController plusBarButton to include action extensions in the alert that's being shown - Implementing improvement (15) from #237 * Fixed (13): restore multiple selection after reloading file list * - Move File Upload and Photo Upload from ClientQueryViewController to distinct Action Extensions - Extend ActionProgressHandler to cater for both publishing and unpublishing progress objects - Replace repeated code with a method to provide a ActionProgressHandler in ClientItemQueryViewController - Make CreateFolderAction require a folder as parent item - Make MoveAction present on the provided ViewController, not its navigationController - Extend error handling in several places * Fixed (21): folder picker not canceleable when navigating into folder and back * - SortBar overhaul / cleanup - remove create folder button from left - left-align the sort option and rename it "Sort by" (from "Sorted by") - turn the sort option button from a ThemeButton to a UIButton and replace the unicode arrow with an elegant chevron - remove sortBar location for action extensions - clean up SortBar code - NSObject+ThemeApplication - replace use of isKindOfClass and force-casts with if let constructs - add support for UIButton themeing - fix "flashing" reording right after opening a connection by setting the OCQuery sort method before starting the query - fix bug where an alert was shown for invalid credentials, but the Edit button did not work - fix ClientRootViewController.closeClient(), so it calls the completionHandler - adjust the editing method to the changed view and navigation controller structure - minor code formatting and style fixes in several places * Fixed (22): no ‘more’ button in directory picker and now swipe to delete * Another small fix for (22) * Fix for multi-selection regression (items automatically selected) when re-entering multi-selection * - Fix UI main thread violation in BookmarkViewController - Fix spelling of CreateFolderAction.identifier value - Simplify implementation of DuplicateAction by refactoring it to use new SDK APIs, addressing issue (7) in #237 - Fix potential future crash in ClientDirectoryPickerViewController by avoiding force-casting - Make OCItem.parentItem in OCItem+Extension more robust using new SDK API - Adapt FileProviderExtension to use new, supported SDK APIs instead of the island implementation that was -findKnownExistingItemInParent:withName: - Add (and comment out) code that lets FileProviderExtension.createDirectoryWithName return as soon as the placeholder item is available - Add empty implementations for trashItemWithIdentifier/untrashItemWithIdentifier/setLastUsedDate/supportedServiceSourcesForItemIdentifier to comply with requirement of overriding all methods raised in the documentation * Fix for (24) refresh animation glitch * Fixed (26) crash when trying to downsample corrupt image file * Version Bump to 116 * Fixed (27): not downloading files which are present offline * Using OCCore.localCopy() to test if the file is already downloaded * Another fix for (27) Not dismissing DisplayViewController when OpenIn action is triggered. * - Update SDK * - Address issue (17) from #237 by bringing up a custom error message when a user likely attempted a cross-server move operation through the Files app * fixed earl grey ui test failures, because UI or logic changed in release_1.0.0 fixes * - Address issue (30) in #237 via SDK update * fixed memory leak, which causes that the viewcontroller was not released (this was recognized, because audio or video keeps playing in the background) * - Updating SDK, fixing issues described for the initial release issue (30) fix * - Fix issue (19) in #237 - Fix issue (30) in #237 with fixes described in owncloud/ios-sdk#46 (comment) * - Addressing (30) in #237 * Fixed (35) handling taps in the PDFThumbnailsView * Some fixes regarding thumbnail size calculation * - Update to latest SDK (to solve (30)) * Fixed (31) plus couple of PDF thumbnail view fixes * Fixed (37) disable horizontal scrolling in the gallery if there is a single item * - Update ios-sdk which now includes important fixes from the ios-sdk feature/sharing branch * - Fix another formatting warning * - Certificate Manager now shows the acceptance reason for user-accepted certificates - Certificate View now shows the acceptance reason description for user-accepted certificates * Few cosmetic changes * Removed unused instance variable * Fixed (38) tap to hide bars -> recalculate image size * Fixed an issue with swipe in the image gallery causing navigation bar to reappear * Fixed (39) Going back to root folder when selected “Browse” tab is tapped * - Fixing two issues from #237: - (25) Double deletion in maintenance mode - (41) Files re-appear in the files list after batch-deleting them * - Fix (42) in #237: considerable CPU use and slow-down in busy/frequently updated directories * - Fixing (33) in #237 via SDK update: give users option to keep file or retry when upload fails * - Fix issue (32) and (40) in #237 by presenting ClientRootViewController - only when the core has been returned by OCCoreManager, showing an activity indicator in the selected cell until then - modally, using a custom push transition to avoid UINavigationController hell - Fix issue where ClientRootViewController would dismiss the lat ClientQueryViewController while also being dismissed, leading to an inconsistent animation when looking closely * - Cleanup * - Cleanup * Version Bump to 117 * Fixed UI tests which broke due to changes made to fix (32) and (40) * Fixed remaining UI tests * - Fix issue where logging in and out of a bookmark in quick succession could lead to hangs opening the bookmark (likely is (32) in #237) * - Fix failing UI tests * - Make certificate detail view more resilient * - Update SDK to add logging around OCCoreManager core requests/returns * - SDK update: - Make OCCoreManager use an administrative queue for every bookmark, so that one connection closing down or opening up can't hold up another - Takes advantage of OCCoreManager managing every bookmark independently - allowing to select another bookmark if the previous one takes longer to open - not show the UI for a bookmark if Settings, Help or Add/Edit Bookmark UI is triggered meanwhile - fix crash caused by force-unwrapping self.core in ClientRootViewController.coreReady() * - Address "(44) Re-save file to the same folder will lead to an error" in #237 * - Avoid showing download progress indicator when viewing files that are already downloaded (issue (46) in #237) - Fix bug in PDFViewerViewController where CoreGraphics would throw an error when using pdfView with zero size (before properly laying it out) * - Clean up DisplayViewController and remove force-casts - Fix (47) "the non-openable files prompt the download progress bar in the "details" view" in #237 * removed localization for "Feedback" button * Feature/heic to jpeg (#363) * Added HEIC to JPEG conversion * Localized strings for photo upload settings * Fixed indentation * Fixed license header * Version Bump to 118 * Made sure that photo metadata is exported
|
Pending issues opened separately. Looking forward for more stuff to include in the release |
* hide beta warning * [Bugfix 1.0.0] Fixed an issue with drag to action not working for some actions * - Fix issue (3) "Oversized thumbnails" - Fix separator insets in item list * - Produce an appropriate error when an upload fails due to insufficient space left on the server (fix (4)) * - Fixing issue (1) and (2) via SDK update * Version Bump to 114 * - disable table cell selection - fixed long status messages, while setting dynamically numbers of lines * Version Bump to 115 * - Fixed (5) where the progress of a file that completed download in the background was shown incorrectly * - Improve progress updates and representation in ClientItemCell * - Fix: indicate activity during last phase of setting up a new bookmark and whenever editing a bookmark and saving it (previously UI seemed stuck for a couple of seconds) * - Added NSError+MessageResolution that resolves the localized description for OCErrors so they are included when serialized, so they become visible in the Files app, too - Fixing issue (8) in #237 * Implemented improvement (13) * - Fix newly introduced potential crash bug in renameItem FP method - Remove trash method and permission flag for items in FP, so "Delete Now" is the only option and Files app shows a warning - Fixing (11) in #237 * - Rename uploadsBarButton to plusBarButton in ClientQueryViewController - Add new action extension location .plusButton - Add Action extensions support to provide UIAlertAction objects - Add .plusButton location to CreateFolder action - Extend the ClientQueryViewController plusBarButton to include action extensions in the alert that's being shown - Implementing improvement (15) from #237 * Fixed (13): restore multiple selection after reloading file list * - Move File Upload and Photo Upload from ClientQueryViewController to distinct Action Extensions - Extend ActionProgressHandler to cater for both publishing and unpublishing progress objects - Replace repeated code with a method to provide a ActionProgressHandler in ClientItemQueryViewController - Make CreateFolderAction require a folder as parent item - Make MoveAction present on the provided ViewController, not its navigationController - Extend error handling in several places * Fixed (21): folder picker not canceleable when navigating into folder and back * - SortBar overhaul / cleanup - remove create folder button from left - left-align the sort option and rename it "Sort by" (from "Sorted by") - turn the sort option button from a ThemeButton to a UIButton and replace the unicode arrow with an elegant chevron - remove sortBar location for action extensions - clean up SortBar code - NSObject+ThemeApplication - replace use of isKindOfClass and force-casts with if let constructs - add support for UIButton themeing - fix "flashing" reording right after opening a connection by setting the OCQuery sort method before starting the query - fix bug where an alert was shown for invalid credentials, but the Edit button did not work - fix ClientRootViewController.closeClient(), so it calls the completionHandler - adjust the editing method to the changed view and navigation controller structure - minor code formatting and style fixes in several places * Fixed (22): no ‘more’ button in directory picker and now swipe to delete * Another small fix for (22) * Fix for multi-selection regression (items automatically selected) when re-entering multi-selection * - Fix UI main thread violation in BookmarkViewController - Fix spelling of CreateFolderAction.identifier value - Simplify implementation of DuplicateAction by refactoring it to use new SDK APIs, addressing issue (7) in #237 - Fix potential future crash in ClientDirectoryPickerViewController by avoiding force-casting - Make OCItem.parentItem in OCItem+Extension more robust using new SDK API - Adapt FileProviderExtension to use new, supported SDK APIs instead of the island implementation that was -findKnownExistingItemInParent:withName: - Add (and comment out) code that lets FileProviderExtension.createDirectoryWithName return as soon as the placeholder item is available - Add empty implementations for trashItemWithIdentifier/untrashItemWithIdentifier/setLastUsedDate/supportedServiceSourcesForItemIdentifier to comply with requirement of overriding all methods raised in the documentation * Fix for (24) refresh animation glitch * Fixed (26) crash when trying to downsample corrupt image file * Version Bump to 116 * Fixed (27): not downloading files which are present offline * Using OCCore.localCopy() to test if the file is already downloaded * Another fix for (27) Not dismissing DisplayViewController when OpenIn action is triggered. * - Update SDK * - Address issue (17) from #237 by bringing up a custom error message when a user likely attempted a cross-server move operation through the Files app * fixed earl grey ui test failures, because UI or logic changed in release_1.0.0 fixes * - Address issue (30) in #237 via SDK update * fixed memory leak, which causes that the viewcontroller was not released (this was recognized, because audio or video keeps playing in the background) * - Updating SDK, fixing issues described for the initial release issue (30) fix * - Fix issue (19) in #237 - Fix issue (30) in #237 with fixes described in owncloud/ios-sdk#46 (comment) * - Addressing (30) in #237 * Fixed (35) handling taps in the PDFThumbnailsView * Some fixes regarding thumbnail size calculation * - Update to latest SDK (to solve (30)) * Fixed (31) plus couple of PDF thumbnail view fixes * Fixed (37) disable horizontal scrolling in the gallery if there is a single item * - Update ios-sdk which now includes important fixes from the ios-sdk feature/sharing branch * - Fix another formatting warning * - Certificate Manager now shows the acceptance reason for user-accepted certificates - Certificate View now shows the acceptance reason description for user-accepted certificates * Few cosmetic changes * Removed unused instance variable * Fixed (38) tap to hide bars -> recalculate image size * Fixed an issue with swipe in the image gallery causing navigation bar to reappear * Fixed (39) Going back to root folder when selected “Browse” tab is tapped * - Fixing two issues from #237: - (25) Double deletion in maintenance mode - (41) Files re-appear in the files list after batch-deleting them * - Fix (42) in #237: considerable CPU use and slow-down in busy/frequently updated directories * - Fixing (33) in #237 via SDK update: give users option to keep file or retry when upload fails * - Fix issue (32) and (40) in #237 by presenting ClientRootViewController - only when the core has been returned by OCCoreManager, showing an activity indicator in the selected cell until then - modally, using a custom push transition to avoid UINavigationController hell - Fix issue where ClientRootViewController would dismiss the lat ClientQueryViewController while also being dismissed, leading to an inconsistent animation when looking closely * - Cleanup * - Cleanup * Version Bump to 117 * Fixed UI tests which broke due to changes made to fix (32) and (40) * Fixed remaining UI tests * - Fix issue where logging in and out of a bookmark in quick succession could lead to hangs opening the bookmark (likely is (32) in #237) * - Fix failing UI tests * - Make certificate detail view more resilient * - Update SDK to add logging around OCCoreManager core requests/returns * - SDK update: - Make OCCoreManager use an administrative queue for every bookmark, so that one connection closing down or opening up can't hold up another - Takes advantage of OCCoreManager managing every bookmark independently - allowing to select another bookmark if the previous one takes longer to open - not show the UI for a bookmark if Settings, Help or Add/Edit Bookmark UI is triggered meanwhile - fix crash caused by force-unwrapping self.core in ClientRootViewController.coreReady() * - Address "(44) Re-save file to the same folder will lead to an error" in #237 * - Avoid showing download progress indicator when viewing files that are already downloaded (issue (46) in #237) - Fix bug in PDFViewerViewController where CoreGraphics would throw an error when using pdfView with zero size (before properly laying it out) * - Clean up DisplayViewController and remove force-casts - Fix (47) "the non-openable files prompt the download progress bar in the "details" view" in #237 * removed localization for "Feedback" button * Feature/heic to jpeg (#363) * Added HEIC to JPEG conversion * Localized strings for photo upload settings * Fixed indentation * Fixed license header * Version Bump to 118 * Made sure that photo metadata is exported * - ownCloud iOS SDK and Xcode update * Fixes for #365 - Offloaded photo import operations off the main thread - Using fullsize image URL to derive filename * Memory use improvements * - Update SDK - include xcscheme options for new configuration variables * - Correct settings in scheme * More memory handling improvements when dealing with image conversion * - ProgressSummarizer updates - now groups progress by type and provides summaries such as "Uploading X of Y files.." that are easier to follow for the user - now prioritizes newer progress submissions over old ones, taking into account the possbility these may be executed earlier due to Sync Engine concurrency * - Clean up Viewer code - Remove unused original DisplayHostViewController - Rename GalleryHostViewController to DisplayViewController - move Viewer code below Client where it logically belongs and split it up into subdirectories - (Re-)add download progress reporting to ClientQueryViewController and initially add it to Display*ViewController classes * - ios-sdk update adding Sync Action categories and concurrency budgets - Clean ups * - Switch back to NSLog from Log.swift in tests (Log.swift is not incuded in the test target) so tests pass - Remove XCTestsCase+Extension as it provides no benefit over Xcode's own messages whn tests start and finish
Release a new version
TASKS:
Git & Code
release/1.0.0(freeze the code) @jesmrecversion_1.0.0App Store
[major].[minor].[patch]Git
release/1.0.0in masterversion_1.0.0If it is required to update third party:
If it is required to update the iOS-SDK version:
release/[major].[minor].[patch](freeze the code)release/1.0.0inmaster1.0.0Version PR: #352
Regression test
https://github.com/owncloud/QA/blob/master/Mobile/iOS-app/Version_1.0.0.md
Bugfixing:
Canceloption Version 1.0.0 #237 (comment) [FIXED]The text was updated successfully, but these errors were encountered: