[feature/branding-builds-customizations] Branding Refinements (#976)

* - updated branding parameter documentation - fastlane: generate all app icons from 1024 pixel file - fastlane: changed binary file name to format "appname-version-datetime.ipa" - fastlane: fixed beta app icon generation, only if key exists * Configuration documentation updated * - updated fastlane and fastlane plugins - gym is now using custom ipa name - fixed beta app icon creation * - fixed documentation typo - added new fastlane lane for ownbrander builds - fixed xcode configuration for release lanes * Configuration documentation updated Co-authored-by: hosy <[email protected]>
owncloud · May 28, 2021 · ff83f4c · ff83f4c
1 parent c312b03
commit ff83f4c
Show file tree

Hide file tree

Showing 8 changed files with 183 additions and 93 deletions.
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -1,64 +1,73 @@
 GEM
   remote: https://rubygems.org/
   specs:
-    CFPropertyList (3.0.2)
+    CFPropertyList (3.0.3)
     addressable (2.7.0)
       public_suffix (>= 2.0.2, < 5.0)
+    artifactory (3.0.15)
     atomos (0.1.3)
-    aws-eventstream (1.1.0)
-    aws-partitions (1.394.0)
-    aws-sdk-core (3.109.3)
+    aws-eventstream (1.1.1)
+    aws-partitions (1.463.0)
+    aws-sdk-core (3.114.0)
       aws-eventstream (~> 1, >= 1.0.2)
       aws-partitions (~> 1, >= 1.239.0)
       aws-sigv4 (~> 1.1)
       jmespath (~> 1.0)
-    aws-sdk-kms (1.39.0)
-      aws-sdk-core (~> 3, >= 3.109.0)
+    aws-sdk-kms (1.43.0)
+      aws-sdk-core (~> 3, >= 3.112.0)
       aws-sigv4 (~> 1.1)
-    aws-sdk-s3 (1.84.1)
-      aws-sdk-core (~> 3, >= 3.109.0)
+    aws-sdk-s3 (1.95.1)
+      aws-sdk-core (~> 3, >= 3.112.0)
       aws-sdk-kms (~> 1)
       aws-sigv4 (~> 1.1)
-    aws-sigv4 (1.2.2)
+    aws-sigv4 (1.2.3)
       aws-eventstream (~> 1, >= 1.0.2)
     babosa (1.0.4)
-    badge (0.12.0)
-      curb (~> 0.9)
+    badge (0.13.0)
       fastimage (>= 1.6)
       fastlane (>= 2.0)
       mini_magick (>= 4.9.4, < 5.0.0)
     claide (1.0.3)
     colored (1.2)
     colored2 (3.1.2)
-    commander-fastlane (4.4.6)
-      highline (~> 1.7.2)
-    curb (0.9.11)
+    commander (4.6.0)
+      highline (~> 2.0.0)
     declarative (0.0.20)
-    declarative-option (0.1.0)
-    digest-crc (0.6.1)
-      rake (~> 13.0)
+    digest-crc (0.6.3)
+      rake (>= 12.0.0, < 14.0.0)
     domain_name (0.5.20190701)
       unf (>= 0.0.5, < 1.0.0)
     dotenv (2.7.6)
-    emoji_regex (3.2.1)
-    excon (0.78.0)
-    faraday (1.1.0)
+    emoji_regex (3.2.2)
+    excon (0.81.0)
+    faraday (1.4.2)
+      faraday-em_http (~> 1.0)
+      faraday-em_synchrony (~> 1.0)
+      faraday-excon (~> 1.1)
+      faraday-net_http (~> 1.0)
+      faraday-net_http_persistent (~> 1.1)
       multipart-post (>= 1.2, < 3)
-      ruby2_keywords
+      ruby2_keywords (>= 0.0.4)
     faraday-cookie_jar (0.0.7)
       faraday (>= 0.8.0)
       http-cookie (~> 1.0.0)
+    faraday-em_http (1.0.0)
+    faraday-em_synchrony (1.0.0)
+    faraday-excon (1.1.0)
+    faraday-net_http (1.0.1)
+    faraday-net_http_persistent (1.1.0)
     faraday_middleware (1.0.0)
       faraday (~> 1.0)
-    fastimage (2.2.0)
-    fastlane (2.167.0)
+    fastimage (2.2.3)
+    fastlane (2.184.0)
       CFPropertyList (>= 2.3, < 4.0.0)
       addressable (>= 2.3, < 3.0.0)
+      artifactory (~> 3.0)
       aws-sdk-s3 (~> 1.0)
       babosa (>= 1.0.3, < 2.0.0)
       bundler (>= 1.12.0, < 3.0.0)
       colored
-      commander-fastlane (>= 4.4.6, < 5.0.0)
+      commander (~> 4.6)
       dotenv (>= 2.1.1, < 3.0.0)
       emoji_regex (>= 0.1, < 4.0)
       excon (>= 0.71.0, < 1.0.0)
@@ -67,18 +76,19 @@ GEM
       faraday_middleware (~> 1.0)
       fastimage (>= 2.1.0, < 3.0.0)
       gh_inspector (>= 1.1.2, < 2.0.0)
-      google-api-client (>= 0.37.0, < 0.39.0)
-      google-cloud-storage (>= 1.15.0, < 2.0.0)
-      highline (>= 1.7.2, < 2.0.0)
+      google-apis-androidpublisher_v3 (~> 0.1)
+      google-apis-playcustomapp_v1 (~> 0.1)
+      google-cloud-storage (~> 1.31)
+      highline (~> 2.0)
       json (< 3.0.0)
       jwt (>= 2.1.0, < 3)
       mini_magick (>= 4.9.4, < 5.0.0)
       multipart-post (~> 2.0.0)
+      naturally (~> 2.2)
       plist (>= 3.1.0, < 4.0.0)
       rubyzip (>= 2.0.0, < 3.0.0)
       security (= 0.1.3)
       simctl (~> 1.6.3)
-      slack-notifier (>= 2.0.0, < 3.0.0)
       terminal-notifier (>= 2.0.0, < 3.0.0)
       terminal-table (>= 1.4.5, < 2.0.0)
       tty-screen (>= 0.6.3, < 1.0.0)
@@ -87,77 +97,92 @@ GEM
       xcodeproj (>= 1.13.0, < 2.0.0)
       xcpretty (~> 0.3.0)
       xcpretty-travis-formatter (>= 0.0.3)
-    fastlane-plugin-badge (1.4.0)
-      badge (~> 0.12.0)
+    fastlane-plugin-appicon (0.16.0)
+      json
+      mini_magick (>= 4.9.4, < 5.0.0)
+    fastlane-plugin-badge (1.5.0)
+      badge (~> 0.13.0)
     fastlane-plugin-json (1.0.0)
     gh_inspector (1.1.3)
-    google-api-client (0.38.0)
+    google-apis-androidpublisher_v3 (0.4.0)
+      google-apis-core (~> 0.1)
+    google-apis-core (0.3.0)
       addressable (~> 2.5, >= 2.5.1)
-      googleauth (~> 0.9)
+      googleauth (~> 0.14)
       httpclient (>= 2.8.1, < 3.0)
       mini_mime (~> 1.0)
       representable (~> 3.0)
       retriable (>= 2.0, < 4.0)
-      signet (~> 0.12)
-    google-cloud-core (1.5.0)
+      rexml
+      signet (~> 0.14)
+      webrick
+    google-apis-iamcredentials_v1 (0.4.0)
+      google-apis-core (~> 0.1)
+    google-apis-playcustomapp_v1 (0.3.0)
+      google-apis-core (~> 0.1)
+    google-apis-storage_v1 (0.4.0)
+      google-apis-core (~> 0.1)
+    google-cloud-core (1.6.0)
       google-cloud-env (~> 1.0)
       google-cloud-errors (~> 1.0)
-    google-cloud-env (1.4.0)
+    google-cloud-env (1.5.0)
       faraday (>= 0.17.3, < 2.0)
-    google-cloud-errors (1.0.1)
-    google-cloud-storage (1.29.1)
+    google-cloud-errors (1.1.0)
+    google-cloud-storage (1.31.1)
       addressable (~> 2.5)
       digest-crc (~> 0.4)
-      google-api-client (~> 0.33)
+      google-apis-iamcredentials_v1 (~> 0.1)
+      google-apis-storage_v1 (~> 0.1)
       google-cloud-core (~> 1.2)
       googleauth (~> 0.9)
       mini_mime (~> 1.0)
-    googleauth (0.14.0)
+    googleauth (0.16.2)
       faraday (>= 0.17.3, < 2.0)
       jwt (>= 1.4, < 3.0)
       memoist (~> 0.16)
       multi_json (~> 1.11)
       os (>= 0.9, < 2.0)
       signet (~> 0.14)
-    highline (1.7.10)
+    highline (2.0.3)
     http-cookie (1.0.3)
       domain_name (~> 0.5)
     httpclient (2.8.3)
     jmespath (1.4.0)
-    json (2.3.1)
-    jwt (2.2.2)
+    json (2.5.1)
+    jwt (2.2.3)
     memoist (0.16.2)
     mini_magick (4.11.0)
-    mini_mime (1.0.2)
+    mini_mime (1.1.0)
     multi_json (1.15.0)
     multipart-post (2.0.0)
     nanaimo (0.3.0)
-    naturally (2.2.0)
+    naturally (2.2.1)
     os (1.1.1)
-    plist (3.5.0)
+    plist (3.6.0)
     public_suffix (4.0.6)
-    rake (13.0.1)
-    representable (3.0.4)
+    rake (13.0.3)
+    representable (3.1.1)
       declarative (< 0.1.0)
-      declarative-option (< 0.2.0)
+      trailblazer-option (>= 0.1.1, < 0.2.0)
       uber (< 0.2.0)
     retriable (3.1.2)
+    rexml (3.2.5)
     rouge (2.0.7)
-    ruby2_keywords (0.0.2)
+    ruby2_keywords (0.0.4)
     rubyzip (2.3.0)
     security (0.1.3)
-    signet (0.14.0)
+    signet (0.15.0)
       addressable (~> 2.3)
       faraday (>= 0.17.3, < 2.0)
       jwt (>= 1.5, < 3.0)
       multi_json (~> 1.10)
     simctl (1.6.8)
       CFPropertyList
       naturally
-    slack-notifier (2.3.2)
     terminal-notifier (2.0.0)
     terminal-table (1.8.0)
       unicode-display_width (~> 1.1, >= 1.1.1)
+    trailblazer-option (0.1.1)
     tty-cursor (0.7.1)
     tty-screen (0.8.1)
     tty-spinner (0.9.3)
@@ -167,6 +192,7 @@ GEM
       unf_ext
     unf_ext (0.0.7.7)
     unicode-display_width (1.7.0)
+    webrick (1.7.0)
     word_wrap (1.0.0)
     xcodeproj (1.19.0)
       CFPropertyList (>= 2.3.3, < 4.0)
@@ -176,14 +202,15 @@ GEM
       nanaimo (~> 0.3.0)
     xcpretty (0.3.0)
       rouge (~> 2.0.7)
-    xcpretty-travis-formatter (1.0.0)
+    xcpretty-travis-formatter (1.0.1)
       xcpretty (~> 0.2, >= 0.0.7)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
   fastlane
+  fastlane-plugin-appicon
   fastlane-plugin-badge
   fastlane-plugin-json
 

diff --git a/doc/CONFIGURATION.json b/doc/CONFIGURATION.json
@@ -643,7 +643,7 @@
     "description" : "Controls whether the user can add accounts.",
     "flatIdentifier" : "branding.can-add-account",
     "key" : "can-add-account",
-    "label" : "branding.can-add-account",
+    "label" : "Allow adding accounts",
     "status" : "advanced",
     "type" : "bool"
   },
@@ -657,7 +657,7 @@
     "description" : "Controls whether the user can edit accounts.",
     "flatIdentifier" : "branding.can-edit-account",
     "key" : "can-edit-account",
-    "label" : "branding.can-edit-account",
+    "label" : "Allow editing accounts",
     "status" : "advanced",
     "type" : "bool"
   },
@@ -711,7 +711,7 @@
     "description" : "Email address to send feedback to. Set to `null` to disable this feature.",
     "flatIdentifier" : "branding.send-feedback-address",
     "key" : "send-feedback-address",
-    "label" : "branding.send-feedback-address",
+    "label" : "Feedback Email address",
     "status" : "advanced",
     "type" : "string"
   },
@@ -751,7 +751,7 @@
     "description" : "URL to documentation for the app. Opened when selecting \"Documentation\" in the settings.",
     "flatIdentifier" : "branding.url-documentation",
     "key" : "url-documentation",
-    "label" : "branding.url-documentation",
+    "label" : "Documentation URL",
     "status" : "advanced",
     "type" : "urlString"
   },
@@ -762,10 +762,10 @@
     "classIdentifier" : "branding",
     "className" : "Branding",
     "defaultValue" : "https://owncloud.com/docs-guides/",
-    "description" : "URL to help for the app. Opened when selecting \"Help\" in the settings.",
+    "description" : "URL to get help for the app. Opened when selecting \"Help\" in the settings.",
     "flatIdentifier" : "branding.url-help",
     "key" : "url-help",
-    "label" : "branding.url-help",
+    "label" : "Help URL",
     "status" : "advanced",
     "type" : "urlString"
   },
@@ -776,10 +776,10 @@
     "classIdentifier" : "branding",
     "className" : "Branding",
     "defaultValue" : "https://owncloud.org/privacy-policy/",
-    "description" : "URL to privacy information for the app. Opened when selecting \"Privacy\" in the settings.",
+    "description" : "URL to get privacy information for the app. Opened when selecting \"Privacy\" in the settings.",
     "flatIdentifier" : "branding.url-privacy",
     "key" : "url-privacy",
-    "label" : "branding.url-privacy",
+    "label" : "Privacy URL",
     "status" : "advanced",
     "type" : "urlString"
   },
@@ -793,7 +793,7 @@
     "description" : "URL to terms of use for the app. Opened when selecting \"Terms Of Use\" in the settings.",
     "flatIdentifier" : "branding.url-terms-of-use",
     "key" : "url-terms-of-use",
-    "label" : "branding.url-terms-of-use",
+    "label" : "Terms of use URL",
     "status" : "advanced",
     "type" : "urlString"
   },
@@ -1874,10 +1874,10 @@
     "categoryTag" : "branding",
     "classIdentifier" : "branding",
     "className" : "Branding",
-    "description" : "Text used for the Help button label",
+    "description" : "Text used for the onboarding button title",
     "flatIdentifier" : "branding.profile-help-button-label",
     "key" : "profile-help-button-label",
-    "label" : "Help button label",
+    "label" : "Onboarding button title",
     "status" : "advanced",
     "subCategory" : "Profile",
     "subCategoryTag" : "profile",
@@ -1889,10 +1889,10 @@
     "categoryTag" : "branding",
     "classIdentifier" : "branding",
     "className" : "Branding",
-    "description" : "Optional URL to help/support resources.",
+    "description" : "Optional URL to onboarding resources.",
     "flatIdentifier" : "branding.profile-help-url",
     "key" : "profile-help-url",
-    "label" : "Help URL",
+    "label" : "Onboarding URL",
     "status" : "advanced",
     "subCategory" : "Profile",
     "subCategoryTag" : "profile",
@@ -1934,10 +1934,10 @@
     "categoryTag" : "branding",
     "classIdentifier" : "branding",
     "className" : "Branding",
-    "description" : "Message shown in an alert before opening the help URL.",
+    "description" : "Message shown in an alert before opening the onboarding URL.",
     "flatIdentifier" : "branding.profile-open-help-message",
     "key" : "profile-open-help-message",
-    "label" : "Open Help message",
+    "label" : "Open onboarding URL message",
     "status" : "advanced",
     "subCategory" : "Profile",
     "subCategoryTag" : "profile",