- Added detection of name conflicts with existing items for creating …

…folders - Addresses issue where folders couldn't be duplicated in the Files app
owncloud · Nov 22, 2018 · fbdeda9 · fbdeda9
1 parent 1989d48
commit fbdeda9
Show file tree

Hide file tree

Showing 2 changed files with 52 additions and 19 deletions.
diff --git a/ios-sdk b/ios-sdk
diff --git a/ownCloud File Provider/FileProviderExtension.m b/ownCloud File Provider/FileProviderExtension.m
@@ -302,6 +302,28 @@ - (void)stopProvidingItemAtURL:(NSURL *)url
 	//	}
 }
 
+#pragma mark - Helpers
+- (OCItem *)findKnownExistingItemInParent:(OCItem *)parentItem withName:(NSString *)name
+{
+	OCPath parentPath;
+	__block OCItem *existingItem = nil;
+
+	if (((parentPath = parentItem.path) != nil) && (name != nil))
+	{
+		OCPath destinationPath = [parentPath stringByAppendingPathComponent:name];
+
+		OCSyncExec(retrieveExistingItem, {
+			[self.core.vault.database retrieveCacheItemsAtPath:destinationPath itemOnly:YES completionHandler:^(OCDatabase *db, NSError *error, OCSyncAnchor syncAnchor, NSArray<OCItem *> *items) {
+				existingItem = items.firstObject;
+				OCSyncExecDone(retrieveExistingItem);
+			}];
+		});
+	}
+
+	return (existingItem);
+}
+
+
 #pragma mark - Actions
 
 // ### Apple template comments: ###
@@ -320,7 +342,31 @@ - (void)createDirectoryWithName:(NSString *)directoryName inParentItemIdentifier
 
 	if ((parentItem = (OCItem *)[self itemForIdentifier:parentItemIdentifier error:&error]) != nil)
 	{
+		// Detect collission with existing items
+		OCItem *existingItem;
+
+		if ((existingItem = [self findKnownExistingItemInParent:parentItem withName:directoryName]) != nil)
+		{
+			completionHandler(nil, [NSError fileProviderErrorForCollisionWithItem:existingItem]);
+			return;
+		}
+
 		[self.core createFolder:directoryName inside:parentItem options:nil resultHandler:^(NSError *error, OCCore *core, OCItem *item, id parameter) {
+			if (error != nil)
+			{
+				if (error.HTTPStatus.code == OCHTTPStatusCodeMETHOD_NOT_ALLOWED)
+				{
+					// Folder already exists on the server
+					OCItem *existingItem;
+
+					if ((existingItem = [self findKnownExistingItemInParent:parentItem withName:directoryName]) != nil)
+					{
+						completionHandler(nil, [NSError fileProviderErrorForCollisionWithItem:existingItem]);
+						return;
+					}
+				}
+
+			}
 			completionHandler(item, error);
 		}];
 	}
@@ -427,26 +473,13 @@ - (void)importDocumentAtURL:(NSURL *)fileURL toParentItemIdentifier:(NSFileProvi
 	if ((parentItem = (OCItem *)[self itemForIdentifier:parentItemIdentifier error:&error]) != nil)
 	{
 		// Detect name collissions
-		OCPath parentPath;
+		OCItem *existingItem;
 
-		if (((parentPath = parentItem.path) != nil) && (importFileName != nil))
+		if ((existingItem = [self findKnownExistingItemInParent:parentItem withName:importFileName]) != nil)
 		{
-			OCPath destinationPath = [parentPath stringByAppendingPathComponent:importFileName];
-			__block OCItem *existingItem = nil;
-
-			OCSyncExec(retrieveExistingItem, {
-				[self.core.vault.database retrieveCacheItemsAtPath:destinationPath itemOnly:YES completionHandler:^(OCDatabase *db, NSError *error, OCSyncAnchor syncAnchor, NSArray<OCItem *> *items) {
-					existingItem = items.firstObject;
-					OCSyncExecDone(retrieveExistingItem);
-				}];
-			});
-
-			if (existingItem != nil)
-			{
-				// Return collission error
-				completionHandler(nil, [NSError fileProviderErrorForCollisionWithItem:existingItem]);
-				return;
-			}
+			// Return collission error
+			completionHandler(nil, [NSError fileProviderErrorForCollisionWithItem:existingItem]);
+			return;
 		}
 
 		// Start import
+8 −0		ownCloudSDK.xcodeproj/project.pbxproj
+30 −0		ownCloudSDK/Errors/NSError+OCHTTPStatus.h
+34 −0		ownCloudSDK/Errors/NSError+OCHTTPStatus.m
+1 −0		ownCloudSDK/Errors/OCHTTPStatus.h
+3 −0		ownCloudSDK/ownCloudSDK.h