Skip to content

Commit

Permalink
Feature/rename (#102)
Browse files Browse the repository at this point in the history
* - Created the RenameViewController similar to what files app does.
- Removed the background color for UINavigationController in NSObject+Theme.swift to prevent errors with blur backgrounds.
- Coded a trailing swipe in ClientQueryViewController.swift with the rename action.

* - In case of a rename only the name is selected by default, the file extension remains untouched for consistency/security.

* - Make the nameTextField resign as first responder when the user taps on cancel.

*  - Adjusted some constraints for non 3.0 scale Screens

* - Update the constraints when there is unknown UITraitCollection

* - Fix for #102 (comment)

* - Fix for #102 (comment)

* Code review changes

* - Change the name of RenameViewController to NamingViewController

* - Merged the two operations into the swipe trailing function: delete and rename

* - Removed autocompletion from the NamingViewController name textfield.

* - Removed unused method from String + Extensions

* - Fix when you try to rename folders.

* - Forget one line for set the default name when provided

* - Enhacement for #102 (comment)

* - Made the textfield resign as first responder in all the cases.

* - NamingViewController:
	- also call completionHandler if cancel is hit
	- make use of tuple result easier to read/maintain
  • Loading branch information
pablocarmu authored Aug 17, 2018
1 parent f3e6271 commit 5155165
Show file tree
Hide file tree
Showing 6 changed files with 424 additions and 2 deletions.
12 changes: 12 additions & 0 deletions ownCloud.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
597A404920AD59EF00B028B2 /* AppLockWindow.swift in Sources */ = {isa = PBXBuildFile; fileRef = 597A404820AD59EF00B028B2 /* AppLockWindow.swift */; };
59D4895220C83F2E00369C2E /* InfoPlist.strings in Resources */ = {isa = PBXBuildFile; fileRef = 59D4895420C83F2E00369C2E /* InfoPlist.strings */; };
6D107AA0B21417432C72755A /* EarlGrey.swift in Sources */ = {isa = PBXBuildFile; fileRef = D7F3B3E74D4B04F9CAF95C09 /* EarlGrey.swift */; };
6E216A642112F58700ED21BD /* NamingViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 6E216A632112F58700ED21BD /* NamingViewController.swift */; };
6E83C77E20A32C1B0066EC23 /* SettingsSection.swift in Sources */ = {isa = PBXBuildFile; fileRef = 6E83C77D20A32C1B0066EC23 /* SettingsSection.swift */; };
6E83C78420A33C180066EC23 /* LAContext+Extension.swift in Sources */ = {isa = PBXBuildFile; fileRef = 6E83C78320A33C180066EC23 /* LAContext+Extension.swift */; };
6EB8EDC52114358400C2BF44 /* folder-create.tvg in Resources */ = {isa = PBXBuildFile; fileRef = 6EB8EDBE2114358300C2BF44 /* folder-create.tvg */; };
Expand Down Expand Up @@ -308,6 +309,7 @@
59D4895320C83F2E00369C2E /* en */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = en; path = en.lproj/InfoPlist.strings; sourceTree = "<group>"; };
59EACA8020CAA37F00F082EE /* es */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = es; path = es.lproj/InfoPlist.strings; sourceTree = "<group>"; };
6CBDF92D3844CF78B20B5770 /* Pods-ownCloudTests.release.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-ownCloudTests.release.xcconfig"; path = "Pods/Target Support Files/Pods-ownCloudTests/Pods-ownCloudTests.release.xcconfig"; sourceTree = "<group>"; };
6E216A632112F58700ED21BD /* NamingViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = NamingViewController.swift; sourceTree = "<group>"; };
6E83C77D20A32C1B0066EC23 /* SettingsSection.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SettingsSection.swift; sourceTree = "<group>"; };
6E83C78320A33C180066EC23 /* LAContext+Extension.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "LAContext+Extension.swift"; sourceTree = "<group>"; };
6EB8EDBE2114358300C2BF44 /* folder-create.tvg */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; name = "folder-create.tvg"; path = "img/filetypes-tvg/folder-create.tvg"; sourceTree = SOURCE_ROOT; };
Expand Down Expand Up @@ -559,6 +561,14 @@
name = Pods;
sourceTree = "<group>";
};
6E216A5C2112F55E00ED21BD /* Actions */ = {
isa = PBXGroup;
children = (
6E216A632112F58700ED21BD /* NamingViewController.swift */,
);
path = Actions;
sourceTree = "<group>";
};
DC1B26FD209CF0D2004715E1 /* Issues Animators */ = {
isa = PBXGroup;
children = (
Expand All @@ -580,6 +590,7 @@
DC3BE0DB2077CC13002A0AC0 /* Client */ = {
isa = PBXGroup;
children = (
6E216A5C2112F55E00ED21BD /* Actions */,
DCFED971208095E200A2D984 /* ClientItemCell.swift */,
DC3BE0DC2077CC13002A0AC0 /* ClientQueryViewController.swift */,
DC3BE0DD2077CC13002A0AC0 /* ClientRootViewController.swift */,
Expand Down Expand Up @@ -1184,6 +1195,7 @@
593BAB97209F8A0500023634 /* AppLockManager.swift in Sources */,
DCFED972208095E200A2D984 /* ClientItemCell.swift in Sources */,
23E22BB720C6A5C40024D11E /* UIDevice+UIUserInterfaceIdiom.swift in Sources */,
6E216A642112F58700ED21BD /* NamingViewController.swift in Sources */,
23F6238120B587EF004FDE8B /* SortMethod.swift in Sources */,
239F1319205A693A0029F186 /* UIColor+Extension.swift in Sources */,
DC3BE0E12077CD4B002A0AC0 /* Synchronized.swift in Sources */,
Expand Down
Loading

0 comments on commit 5155165

Please sign in to comment.