-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instant thumbnails showing #511
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Spacefish - I removed your grayscale filter as it wasn't working on Firefox and in my tests on mobile, making things slower, but this can be re-added in a separate PR where we can better test it in isolation. |
Seems to work in Chrome 48.0.2564.103 (64-bit) on Mac OS with oc 9.0-pre. |
7 tasks
(cherry picked from commit 11d33eb)
(cherry picked from commit 0af1416)
oparoz
force-pushed
the
instant-thumbnails-showing-2
branch
from
February 12, 2016 03:02
0a8e040
to
61d7a41
Compare
This is now part of the next-9.1 branch, but I'm leaving it open so that people can still express themselves. |
4 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #497
Improves the feedback shown to users to let them know that something is happening when thumbnails have not been generated yet. This replaces the spinner added below the row.
Fixes #29
The improvements are better seen on albums which contain sub-albums as these should show some activity before the full row has been rendered.
Screencasts
Note: the refresh rate in the videos is quite low, so this is not reflective of the smootheness of the animation
With cached thumbnails
http://screencast-o-matic.com/watch/cDn6n7hR39
You can see that once the album is cached, there is no resizing taking place any more
On an empty cache
http://screencast-o-matic.com/watch/cDn6nEhR3E
Features:
Caveats
Tested on
@jancborchardt @jospoortvliet @setnes @deMattin @arkascha @elpraga @sualko @Bugsbane @mmattel