Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instant thumbnails showing #511

Closed
wants to merge 5 commits into from
Closed

Conversation

oparoz
Copy link
Contributor

@oparoz oparoz commented Feb 10, 2016

Replaces #497

Improves the feedback shown to users to let them know that something is happening when thumbnails have not been generated yet. This replaces the spinner added below the row.

Fixes #29

The improvements are better seen on albums which contain sub-albums as these should show some activity before the full row has been rendered.

Screencasts

Note: the refresh rate in the videos is quite low, so this is not reflective of the smootheness of the animation

With cached thumbnails
http://screencast-o-matic.com/watch/cDn6n7hR39

You can see that once the album is cached, there is no resizing taking place any more

On an empty cache
http://screencast-o-matic.com/watch/cDn6nEhR3E

Features:

  • Semi-opaque row while it's being filled
  • Spinners on images in albums
  • Spinners on single images on row (with caveat, see below)

Caveats

  • Since we don't have the real size of the images, the next image or its spinner are sometimes misaligned. It's currently impossible to fix and has to be accepted as a side-effect of being able to show some information before having the full picture
  • When resizing the window on a desktop, there is a flashing effect as each time the wall is being redrawn, the opacity goes back to being semi-transparent until the images are resized. In my experience, the fix involves introducing and monitoring a state to know if we're currently in a resizing loop. I don't think it's worth for me to invest time to improve this, but a PR can certainly be introduced later if someone finds a better way
  • On low powered devices, there may be a bit of stuttering when resizing very wide images. I find this acceptable, compared to the advantages.

Tested on

  • Windows 10 Firefox, Chrome
  • OSX Chrome
  • BlackBerry 10
  • iOS
  • Android 4.3

@jancborchardt @jospoortvliet @setnes @deMattin @arkascha @elpraga @sualko @Bugsbane @mmattel

@oparoz oparoz self-assigned this Feb 10, 2016
@oparoz oparoz added this to the 9.0-current milestone Feb 10, 2016
@oparoz
Copy link
Contributor Author

oparoz commented Feb 10, 2016

@Spacefish - I removed your grayscale filter as it wasn't working on Firefox and in my tests on mobile, making things slower, but this can be re-added in a separate PR where we can better test it in isolation.

@sualko
Copy link

sualko commented Feb 10, 2016

Seems to work in Chrome 48.0.2564.103 (64-bit) on Mac OS with oc 9.0-pre.

@oparoz oparoz mentioned this pull request Feb 11, 2016
8 tasks
@oparoz oparoz modified the milestones: 9.1-next, 9.0-current Feb 11, 2016
@oparoz oparoz mentioned this pull request Feb 11, 2016
7 tasks
@oparoz oparoz force-pushed the instant-thumbnails-showing-2 branch from 0a8e040 to 61d7a41 Compare February 12, 2016 03:02
@oparoz
Copy link
Contributor Author

oparoz commented Feb 12, 2016

This is now part of the next-9.1 branch, but I'm leaving it open so that people can still express themselves.

@oparoz oparoz closed this Mar 1, 2016
@oparoz oparoz deleted the instant-thumbnails-showing-2 branch March 1, 2016 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show thumbnails as soon as they're received
3 participants