-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several pictures and still get 'No pictures found! If you upload pictures in the files app, they will be displayed here.' #69
Comments
It seems oC can't read a file located 5 levels lower than root. It would be great if you could identify which folder and file is causing this. I should also make it so that an exception like this doesn't break the rendering of the whole view. |
i have applied the patch , the error is gone but i just get a circle spinning forever... |
The spinning circle means that either the server is not returning anything or the Javascript doesn't understand the reply. Percents are not possible as we're exploring the filesystem, but it should be possible to use the same technique used for thumbnails to stream back the list of files as we find them. And once #29 is implemented, it should be possible to even start building the view as soon as we receive files. |
Well, though i still dont know where the problem is, i found out that if i exclude exactly 3 folders (using .nomedia) that contains about 230 picture files, the ~8000 pictures left will load fine in galleryplus. ./Análises/Microscopia(26-04-2012)/.nomedia I will try to get at least one folder that crashes at the lowest level, and check the pictures in there. |
OK, i have found a subfolder in the leaf of the directory tree containing 28 pictures , and if i do not exclude this folder, galleryplus will keep spinning forever. qeusta5 001.jpg JPEG 1700x2338 1700x2338+0+0 8-bit DirectClass 329KB 0.000u 0:00.010 |
I left just one single file/image in the folder and it will break the whole processing. |
Thanks! What happens if you rename that test file? And there are 2 issues here:
|
Yes, they can be seen on FIles App and they have the small thumbnails. |
And do you get large previews? |
If by large preview you mean that clicking in the file name the picture will open, yes , i do. |
OK, so the app should not ignore it. The problem is why doesn't it have a proper node type... |
If you enable the Firefox debugger and go to the network tab, there is a request made to |
I have to admit that it is really strange. I copied the file to another user folder and there galleryplus display the file just fine. I am starting to guess there's something about the whole path. Original user has that file inside $USER/netbook/documentos/Desktop/Mask - Mask/Disciplinas/Técnicas microscópicas de caracterização/LISTA MASK/ |
in firefox debugger i can see the correct PATH , including all accents in the currentfolder param |
I get message: |
OK, you get this message because the failure happens in the current folder. My theory is that the filesystem is corrupt. That folder is not reachable. If you move these pictures one folder up, you should be able to see them in gallery mode and if you put any picture in that folder it won't show. |
If this is confirmed, I'd still like to be able to ignore that folder properly. |
Why does it load fine in Files app ? sudo fsck -Cvyf /dev/mapper/OWNCLOUD
|
By virtual filesystem, I mean the one built by oC to reference files and folders, maybe the cache is simply corrupt. |
Just moved the whole folder to root directory. Any other information i can provide ? |
How can i clear the cache ? |
Since the folder is the one which has problems, you need to move the pictures out of that folder and into another one named just the same. Now, when the problematic folder is empty, it should still break the rendering of the gallery, the only way to stop it doing that would be to put a ".nomedia" file in the folder above it. I'd like you to keep at least one broken one to see if I can build a workaround. |
|
I meant moving and renaming in oC, but I guess it also works from the console :) EDIT: I reread and so it seems it was a problem with the folder Try moving the files to another folder which is not directly above the broken one so that we can confirm that files are fine. In the patch you're trying, I've silenced the error, but let's see if there is something interesting in there.
I can't simulate the problem in my setup. If I return an empty string or throw an exception, things work as expected and the folder disappears. |
Yes, LISTA.BAK is blocking. |
Just to be sure, you have to be one folder above LISTA.BAK to get something in the logs |
OK. Actually right now (after last pulling) galleryplus stopped working for all users. |
I apologise, I used the wrong variable name...Try now |
Other users now ok. Broken user still broken (spinning forever) |
And do you get the paths to these files in the logs? |
Do your other files also have spaces in the filename? |
i get several paths , and it stops in these: {"reqId":"03d9dd4975905aca14230c112c0e329b","remoteAddr":"192.168.254.2","app":"galleryplus","message":"Sub-Node path : /USUARIO/files/shared_with_me/Coisas/CERTIFICADOS/ORIGINAIS/Scanned Document-03.jpg","level":0,"time":"2015-03-08T15:55:58-03:00","method":"GET","url":"/owncloud/index.php/apps/galleryplus/images?currentfolder="} What you mean by other files ? other users ? |
I meant other files by the same user, but I can see that you have other files with spaces in them "Scanned Document-05.jpg" I've pushed a change to protect the app from getPath(). Let me know... |
Still spinning forever, but this time i got about 8150 "sub-node path' lines in the log. {"reqId":"8b7c9bac36ce225bbd2470abbe0b071a","remoteAddr":"192.168.254.2","app":"galleryplus","message":"Image path : /USUARIO/files/shared_with_me/Coisas/CERTIFICADOS/ORIGINAIS/Scanned Document-05.jpg","level":0,"time":"2015-03-08T16:28:46-03:00","method":"GET","url":"/owncloud/index.php/apps/galleryplus/images?currentfolder="} |
I'm guessing this is happening just before going into the folder which has problems... |
You're not getting any javascript errors by any chance? |
not really :/ |
What's scary is that the initial scan is still picking up 8k+ files... at some point this is going to have to change... |
Should the scan get only picture files ? |
You see all the nodes when enabling that debug line. Pull the latest changes and disable that line. |
pulled, still spinning , stopped here: {"reqId":"b27331b217e7fb2369a5356e57ee1fd8","remoteAddr":"192.168.254.2","app":"galleryplus","message":"Image path : /USUARIO/files/shared_with_me/Coisas/CERTIFICADOS/ORIGINAIS/Scanned Document-04.jpg","level":0,"time":"2015-03-08T18:06:41-03:00","method":"GET","url":"/owncloud/index.php/apps/galleryplus/images?currentfolder="} |
In Firefox, does |
Yes, JSON object Maybe this help, in debuger i can see a 414 GET error with params: |
Ah, yes, that helps. You've been hit by a separate bug: #27 |
Nice =) |
Yes, that will go to master and the fix for #27 is on another branch, but that one does not contain the fixes from here, so that won't help until I merge everything... but soon :D |
OK, so let me know if master now works for you. if you've made changes, the quickest thing to do is |
It worked !!!!!! |
That directory is fine, but others still wont load (spinning forever). |
I should really get rid of that notice... but it's harmless. Check Firefox, you're probably still affected by the 414. Master only contains a partial fix for #27, the real one involves about a week's worth of work. |
You are right, still 414; |
:) |
Gallery+ keeps showing "No pictures found! If you upload pictures in the files app, they will be displayed here." for some users, even though they have plenty of pictures.
The problem appears to be in the top root folder (accessed by clicking apps/gallery+). If i browse to some picture folder in FILES app, i can click the tile button and gallery+ can see the files, and even go up a few folder levels.
Log shows :
{"reqId":"836126f4bdfaa632bcdb2b7e8edd6e06","remoteAddr":"192.168.254.2","app":"index","message":"Exception: {"Message":"","Code":0,"Trace":"#0 \/var\/www\/owncloud\/lib\/private\/files\/node\/node.php(321): OC\Files\Node\Node->getFileInfo()\n#1 \/var\/www\/owncloud\/apps\/galleryplus\/service\/infoservice.php(165): OC\Files\Node\Node->getType()\n#2 \/var\/www\/owncloud\/apps\/galleryplus\/service\/infoservice.php(220): OCA\GalleryPlus\Service\InfoService->searchFolder(Object(OC\Files\Node\Folder), 6)\n#3 \/var\/www\/owncloud\/apps\/galleryplus\/service\/infoservice.php(178): OCA\GalleryPlus\Service\InfoService->searchSubFolders(Array, 0, 5)\n#4 \/var\/www\/owncloud\/apps\/galleryplus\/service\/infoservice.php(220): OCA\GalleryPlus\Service\InfoService->searchFolder(Object(OC\Files\Node\Folder), 5)\n#5 \/var\/www\/owncloud\/apps\/galleryplus\/service\/infoservice.php(178): OCA\GalleryPlus\Service\InfoService->searchSubFolders(Array, 0, 4)\n#6 \/var\/www\/owncloud\/apps\/galleryplus\/service\/infoservice.php(220): OCA\GalleryPlus\Service\InfoService->searchFolder(Object(OC\Files\Node\Folder), 4)\n#7 \/var\/www\/owncloud\/apps\/galleryplus\/service\/infoservice.php(178): OCA\GalleryPlus\Service\InfoService->searchSubFolders(Array, 0, 3)\n#8 \/var\/www\/owncloud\/apps\/galleryplus\/service\/infoservice.php(220): OCA\GalleryPlus\Service\InfoService->searchFolder(Object(OC\Files\Node\Folder), 3)\n#9 \/var\/www\/owncloud\/apps\/galleryplus\/service\/infoservice.php(178): OCA\GalleryPlus\Service\InfoService->searchSubFolders(Array, 0, 2)\n#10 \/var\/www\/owncloud\/apps\/galleryplus\/service\/infoservice.php(220): OCA\GalleryPlus\Service\InfoService->searchFolder(Object(OC\Files\Node\Folder), 2)\n#11 \/var\/www\/owncloud\/apps\/galleryplus\/service\/infoservice.php(178): OCA\GalleryPlus\Service\InfoService->searchSubFolders(Array, 0, 1)\n#12 \/var\/www\/owncloud\/apps\/galleryplus\/service\/infoservice.php(220): OCA\GalleryPlus\Service\InfoService->searchFolder(Object(OC\Files\Node\Folder), 1)\n#13 \/var\/www\/owncloud\/apps\/galleryplus\/service\/infoservice.php(178): OCA\GalleryPlus\Service\InfoService->searchSubFolders(Array, 0, 0)\n#14 \/var\/www\/owncloud\/apps\/galleryplus\/service\/infoservice.php(139): OCA\GalleryPlus\Service\InfoService->searchFolder(Object(OC\Files\Node\Folder))\n#15 \/var\/www\/owncloud\/apps\/galleryplus\/controller\/servicecontroller.php(169): OCA\GalleryPlus\Service\InfoService->getImages(Array)\n#16 [internal function]: OCA\GalleryPlus\Controller\ServiceController->getImages()\n#17 \/var\/www\/owncloud\/lib\/private\/appframework\/http\/dispatcher.php(158): call_user_func_array(Array, Array)\n#18 \/var\/www\/owncloud\/lib\/private\/appframework\/http\/dispatcher.php(86): OC\AppFramework\Http\Dispatcher->executeController(Object(OCA\GalleryPlus\Controller\ServiceController), 'getImages')\n#19 \/var\/www\/owncloud\/lib\/private\/appframework\/app.php(97): OC\AppFramework\Http\Dispatcher->dispatch(Object(OCA\GalleryPlus\Controller\ServiceController), 'getImages')\n#20 \/var\/www\/owncloud\/lib\/private\/appframework\/routing\/routeactionhandler.php(44): OC\AppFramework\App::main('ServiceControll...', 'getImages', Object(OC\AppFramework\DependencyInjection\DIContainer), Array)\n#21 [internal function]: OC\AppFramework\routing\RouteActionHandler->__invoke(Array)\n#22 \/var\/www\/owncloud\/lib\/private\/route\/router.php(250): call_user_func(Object(OC\AppFramework\routing\RouteActionHandler), Array)\n#23 \/var\/www\/owncloud\/lib\/base.php(767): OC\Route\Router->match('\/apps\/gallerypl...')\n#24 \/var\/www\/owncloud\/index.php(36): OC::handleRequest()\n#25 {main}","File":"\/var\/www\/owncloud\/lib\/private\/files\/node\/node.php","Line":65}","level":4,"time":"2015-03-07T19:49:49-03:00"}
The text was updated successfully, but these errors were encountered: