-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a busy spinner whilst loading thumbs #130
Comments
I agree. I'm adding the original Gallery ticket here for reference: |
Totally agree here. We need loading feedback, otherwise it’s not clear if it’s still loading or there’s an error (or pictures are missing which you know are there). @arkascha’s suggestion of putting it in the middle of the row to come is good. |
The best way to implement this would be via #29 |
@oparoz the spinner could also just be shown as the background image of the row to be rendered (via class |
@jancborchardt - No, because the row is not added to the DOM until it's been filled. It already has the spinning wheel, but we just never see it. It's a regression from when the photowall was implemented. |
One solution to explore is to add an extra DOM element containing only the spinner and to hide it when all thumbnails have been loaded. |
@oparoz yeah, would be very good for feedback, as we talked about. |
Use master to test |
You're advised to use a custom CSS spinner if you configure the background colour of your albums as the default one doesn't look good. |
@rperezb can you please assign |
@Dianafg76 did you test it on Friday? |
Just to be clear, it's the spinner you see at the bottom of the rows, as they're loading. |
I tested this issue and it is working ok. |
The apps shows a busy spinner whilst initially loading an album. Great.
The same should happen whilst still loading additional thumbs, probably centered in the row to come.
Otherwise there is no means to tell if loading has finished.
The text was updated successfully, but these errors were encountered: