Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a busy spinner whilst loading thumbs #130

Closed
arkascha opened this issue May 5, 2015 · 13 comments · Fixed by #319
Closed

Add a busy spinner whilst loading thumbs #130

arkascha opened this issue May 5, 2015 · 13 comments · Fixed by #319
Assignees
Milestone

Comments

@arkascha
Copy link

arkascha commented May 5, 2015

The apps shows a busy spinner whilst initially loading an album. Great.
The same should happen whilst still loading additional thumbs, probably centered in the row to come.
Otherwise there is no means to tell if loading has finished.

@oparoz
Copy link
Contributor

oparoz commented May 5, 2015

I agree. I'm adding the original Gallery ticket here for reference:
#150

icewind1991 added a commit that referenced this issue Jul 25, 2015
@jancborchardt
Copy link
Member

Totally agree here. We need loading feedback, otherwise it’s not clear if it’s still loading or there’s an error (or pictures are missing which you know are there). @arkascha’s suggestion of putting it in the middle of the row to come is good.

@oparoz
Copy link
Contributor

oparoz commented Jul 28, 2015

The best way to implement this would be via #29
Otherwise we would have to create/destroy lots of divs, just to show the spinning wheel.

@jancborchardt
Copy link
Member

@oparoz the spinner could also just be shown as the background image of the row to be rendered (via class .icon-loading which can then simply be removed).

@oparoz
Copy link
Contributor

oparoz commented Jul 28, 2015

@jancborchardt - No, because the row is not added to the DOM until it's been filled. It already has the spinning wheel, but we just never see it. It's a regression from when the photowall was implemented.

@oparoz oparoz added this to the 8.2-current milestone Aug 31, 2015
@oparoz
Copy link
Contributor

oparoz commented Sep 8, 2015

One solution to explore is to add an extra DOM element containing only the spinner and to hide it when all thumbnails have been loaded.

@oparoz oparoz added the ready label Sep 8, 2015
@jancborchardt
Copy link
Member

@oparoz yeah, would be very good for feedback, as we talked about.

@oparoz
Copy link
Contributor

oparoz commented Sep 13, 2015

Use master to test

@oparoz oparoz reopened this Sep 13, 2015
@oparoz
Copy link
Contributor

oparoz commented Sep 19, 2015

You're advised to use a custom CSS spinner if you configure the background colour of your albums as the default one doesn't look good.

@ghost
Copy link

ghost commented Sep 21, 2015

@rperezb can you please assign

@rperezb rperezb mentioned this issue Sep 23, 2015
2 tasks
@rperezb
Copy link

rperezb commented Oct 5, 2015

@Dianafg76 did you test it on Friday?

@oparoz
Copy link
Contributor

oparoz commented Oct 5, 2015

Just to be clear, it's the spinner you see at the bottom of the rows, as they're loading.
The easiest way to see it is to delete all the thumbnails and to reload an album in Gallery

@Dianafg76
Copy link

I tested this issue and it is working ok.
Server v {"installed":true,"maintenance":false,"version":"8.2.0.7","versionstring":"8.2 beta1","edition":""}
Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants