Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prohibit enabling encryption when S3 Object Storage is configured #487

Merged
merged 7 commits into from
Oct 11, 2021

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Sep 23, 2021

This information was initially mentioned in the docs, but got lost over time. See owncloud/docs#4033.

Related to owncloud/core#39263.

image

image

@CLAassistant
Copy link

CLAassistant commented Sep 23, 2021

CLA assistant check
All committers have signed the CLA.

@JammingBen JammingBen mentioned this pull request Sep 23, 2021
44 tasks
@JammingBen JammingBen changed the title Add a warning that encryption is not compatible and might break things Prohibit enabling encryption when S3 Object Storage is configured Sep 23, 2021
@mmattel
Copy link
Contributor

mmattel commented Sep 28, 2021

Q: do we disable encryption in general or only for mount points using S3 OS ?

@AlexAndBear
Copy link

A: In general, this is for setting s3 as primary storage

@JammingBen
Copy link
Contributor Author

@phil-davis Any idea why the pipeline fails? https://drone.owncloud.com/owncloud/files_primary_s3/2496/3/4

Command is registered properly IMO...

@JammingBen JammingBen force-pushed the encryption-warning branch 3 times, most recently from 2e91390 to 03fc381 Compare October 11, 2021 14:31
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@AlexAndBear AlexAndBear merged commit c33f0c2 into master Oct 11, 2021
@delete-merged-branch delete-merged-branch bot deleted the encryption-warning branch October 11, 2021 16:19
@jnweiger jnweiger mentioned this pull request Nov 18, 2021
@jnweiger
Copy link
Contributor

jnweiger commented Nov 18, 2021

Not confirmed

Through the admin UI, encryption 1.5.1 can be enabled together with files_primary_s3 1.1.3 in server 10.8.0, and in yesterday's daily.

-> reopening owncloud/core#39263

@jnweiger
Copy link
Contributor

Fixed in 1.1.3-rc3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants