Add apache req-resp limits #555
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmattel
requested review from
dragonchaser,
jnweiger,
phil-davis,
individual-it and
EParzefall
EParzefall
approved these changes
Jun 29, 2023
jnweiger
requested changes
Jun 29, 2023
There was a problem hiding this comment.
I don't know.
Adding these directives may cause apache to allocate and free 128k on each call.
That is a probably wasteful.
I'd suggest to rather find the maximum real life header size. (This monstrous token + a few kb) and round that up to the nearest power of two, or so ...
Guess that 16k or 32k is sufficient in any case.
Co-authored-by: Jürgen Weigert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds configuration to the apache config to cover large headers for reverse proxying.
We have done the same for nginx, see Finalize the nginx Configuration.
Setting this to draft as I would like to get a review if the settings are correct. If there is an unmentioned apache specialist that could do a review pls invite.