Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add change log #25

Merged
merged 1 commit into from
Sep 13, 2017
Merged

add change log #25

merged 1 commit into from
Sep 13, 2017

Conversation

mrow4a
Copy link
Contributor

@mrow4a mrow4a commented Aug 31, 2017

No description provided.

@mrow4a mrow4a requested review from PVince81 and pmaier1 August 31, 2017 13:36
@mrow4a mrow4a mentioned this pull request Aug 31, 2017
2 tasks
@PVince81
Copy link
Contributor

PVince81 commented Sep 1, 2017

no entries as this is the initial version ?

@mrow4a
Copy link
Contributor Author

mrow4a commented Sep 1, 2017

I mean, for now there are nearly none, maybe the icon and LDAP problem. I did not manage to make the build/gen_changelog.sh script run on this app

@PVince81
Copy link
Contributor

PVince81 commented Sep 1, 2017

@mrow4a try this: vim .git/config and append ".git" at the end of the repo URL.

@PVince81
Copy link
Contributor

since there wasn't any previous releases, there aren't any changes to be documented here.

Please add a "Initial release" entry and remove the empty sections.

@pmaier1
Copy link
Contributor

pmaier1 commented Sep 12, 2017

Please adapt and merge this until Thursday for that we can release with 10.0.3. Thanks!

@mrow4a mrow4a force-pushed the add-changelog branch 2 times, most recently from eb6d231 to 40ce3df Compare September 13, 2017 11:52
CHANGELOG.md Outdated

The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).

## [Unreleased]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this empty section

CHANGELOG.md Outdated

## [Unreleased]

## 0.1.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we agreed that 0.1.1 will be the released version and no one will bump it ?

@PVince81
Copy link
Contributor

Okay I see that this is the last item in #12, so just remove "Unreleased" and make "0.1.1" clickable to see the commits until v0.1.1.

@mrow4a
Copy link
Contributor Author

mrow4a commented Sep 13, 2017

Hmm, but according to changelog documentation this section can be empty and is just a shortcut to commits which are unreleased @PVince81

@PVince81 PVince81 merged commit c28dc6d into master Sep 13, 2017
@PVince81 PVince81 deleted the add-changelog branch September 13, 2017 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants