Register section for the app in settings #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks 👍 |
sharidas
force-pushed
the
customgroups-consistancy-task16
branch
3 times, most recently
from
46563b3
to
52c00ff
Compare
|
@SergioBertolinSG why is it failing for mailhog here even though we don't care about email here ? |
|
Because tests here are directly affected by changes in core. That variable is missing in the config.yml I can try to fix it. |
|
Modified here #63 . |
|
@sharidas please rebase for CI |
|
then merge if it passes |
Register section for the app in settings Signed-off-by: Sujith H <[email protected]>
sharidas
force-pushed
the
customgroups-consistancy-task16
branch
from
52c00ff
to
27c43fd
Compare
|
@PVince81 sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Register section for the app in settings
Signed-off-by: Sujith H [email protected]