Do not count the size of shared folder on total #5399
Conversation
|
@frisco82 can you please rebase? THX |
|
No problem, rebased. |
|
Closing this as duplicate of #2796. Let's follow up there. |
|
Sorry guys, I meant to close another issue. Reopening. |
|
@frisco82 can you confirm that shared files are indeed NOT counted in a user's quota ? |
| @@ -610,6 +598,24 @@ var FileList={ | |||
| } | |||
| } | |||
| }, | |||
| _calculateFileSummary: function() { | |||
| var result = new Array(); | |||
| result['totalDirs'] = 0; | |||
There was a problem hiding this comment.
If you come from the PHP world you might be interested to know that you can also write this as:
result.totalDirs = 0;
😄
There was a problem hiding this comment.
Hmm, I see this all over the place. Do you might changing it and use the dot notation instead ? It makes the code more readable.
Quotas are a mystery for me, I can assure that under windows and 1 level sharing, shared items do not counts toward quota. |
|
@frisco82 have a look at #2796 Please also fix this PR as it fixes part of the issues 😃 |
|
Dot notation fixed. |
|
Excellent Indy... I mean @frisco82 😉 👍 |
|
CC @owncloud/designers for information. This will make whatever is displayed in the list match the real thing. This needs another reviewer @karlitschek @DeepDiver1975 @Kondou-ger @kabum |
| } else if ($value.data('type') === 'file') { | ||
| result.totalFiles++; | ||
| } | ||
| if ($value.data('size') !== undefined && $value.data('id') !== -1) { //Skip shared as it does not count toward quota |
Changed all array access to dot notation Split comment in a second line
|
Test passed. |
|
@Kondou-ger the long line has been split up! |
ghost
assigned 
|
👍 Thanks! |
Do not count the size of shared folder on total
Not sure if it is a desired feature or not, but as it does not count toward users quota is a bit misleading to see a total size over your quota and that leads to users creating issues like: #5362, #5363
I think that a global progress bar with different colours as it progresses, is a lot easier to understand but that is a new feature with UI and I don't know how do you manage that.