Public API OC6 - introduce lib/private #5039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/public Conflicts: lib/private/vcategories.php
|
I'm not in favor of moving everything one level down needlessly (imo), but the code looks fine |
well - this was the result of the discussion 2 weeks ago: |
|
Test passed. |
|
👍 Works great |
|
Test passed. |
|
👍 Patch looks okay. Didn't test. |
MorrisJobke
added a commit
that referenced
this pull request
Oct 1, 2013
Public API OC6 - introduce lib/private
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move the private namespace OC into lib/private - OCP will stay in lib/public
I had to resubmit this issue because the branch appframework-master has been merged
As discussed in #4863 (comment) we clearly separate public namespace from private namespace.
lib/public - OCP
lib/private - OC
@karlitschek @blizzz @bartv2 @bantu @icewind1991 @kabum THX