Public session #4888
Merged
Public session #4888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good 👍 |
|
Test failed. |
|
Test failed. |
|
@tanghus Awesome! I'll have a look later why jenkins is failing. |
|
I know why ;) 2 mins. |
|
Should be fixed now. |
27 tasks
|
👍 |
|
|
||
| interface ISession { | ||
| /** | ||
| * @param string $key |
There was a problem hiding this comment.
These methods are quite self explaining - But I still like to have a little sentence here describing what the methods do.
We will generate the API documentation from the public interfaces and classes apt.owncloud.org
THX
There was a problem hiding this comment.
But I still like to have a little sentence here describing what the methods do.
Added basic docs @DeepDiver1975
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add interface for Session and add getter in server container.
Refs #4863
@DeepDiver1975 @karlitschek @icewind1991