Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type checks to SFTP.php #41240

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

harrykipper
Copy link

Description

Adds a type check

Related Issue

Fixes #41159

Motivation and Context

Removes errors from the log

How Has This Been Tested?

  • test environment: large 1000+ users installation

Screenshots (if appropriate):

Types of changes

  • [X ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • [X ] Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

Copy link

update-docs bot commented Apr 26, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@CLAassistant
Copy link

CLAassistant commented Apr 26, 2024

CLA assistant check
All committers have signed the CLA.

[tx] updated from transifex
@DeepDiver1975
Copy link
Member

@harrykipper please bring this to a mergable condition. THX

@iasdeoupxe iasdeoupxe mentioned this pull request Aug 28, 2024
11 tasks
@phil-davis
Copy link
Contributor

@harrykipper commit messages need to conform to https://www.conventionalcommits.org/en/v1.0.0/

A changelog needs to be added here.

You started this PR directly from the master branch in your fork. I suggest that you use a different branch(es) for making PRs and keep the master in your fork up-to-date with core master.

@iasdeoupxe
Copy link
Contributor

A changelog needs to be added here.

Can be pulled from #41309

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trying to access array offset on value of type bool at apps/files_external/lib/Lib/Storage/SFTP.php
5 participants