Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]Refactor MCKOL request to non-existence user and to another users endpoint #40495

Merged
merged 4 commits into from
Nov 30, 2022
Merged

[tests-only][full-ci]Refactor MCKOL request to non-existence user and to another users endpoint #40495

merged 4 commits into from
Nov 30, 2022

Conversation

SagarGi
Copy link
Member

@SagarGi SagarGi commented Nov 15, 2022

Description

  • This PR adjust the response status code when a user make a MCKOL request to non-existence-user and other user's endpoint.
  • Adds the bug demonstration test for the MCKOL request for oc10

Related Issue

Motivation and Context

How Has This Been Tested?

  • Locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@SagarGi SagarGi self-assigned this Nov 15, 2022
@SagarGi SagarGi marked this pull request as ready for review November 15, 2022 07:01
@SagarGi SagarGi mentioned this pull request Nov 15, 2022
Closed
@SagarGi SagarGi changed the title [tests-only][full-ci]Refactor MCKOL request to non-existence user and to another users endpoint [tests-only]Refactor MCKOL request to non-existence user and to another users endpoint Nov 15, 2022
@amrita-shrestha
Copy link
Contributor

amrita-shrestha commented Nov 16, 2022 •
edited
Loading

@SagarGi ocis issue owncloud/ocis#5049 .Take reference of it

@SagarGi SagarGi force-pushed the refactorStatusCodeForMCKOL branch 2 times, most recently from bf2e35d to 4c9878c Compare November 18, 2022 11:00
@ownclouders
Copy link
Contributor

ownclouders commented Nov 18, 2022 •
edited
Loading

💥 Acceptance tests pipeline apiVersions-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/37323/74

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiOnSqlite-sqlite-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/37307/175

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiProxySmoke-8-7-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/37307/173

@SagarGi SagarGi force-pushed the refactorStatusCodeForMCKOL branch 2 times, most recently from 4924236 to 4cc2ac7 Compare November 23, 2022 06:27
kiranparajuli589
kiranparajuli589 reviewed Nov 23, 2022
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :+1 few improvements:

tests/TestHelpers/WebDavHelper.php Outdated Show resolved Hide resolved
tests/TestHelpers/WebDavHelper.php Outdated Show resolved Hide resolved
tests/TestHelpers/WebDavHelper.php Outdated Show resolved Hide resolved
@SagarGi SagarGi force-pushed the refactorStatusCodeForMCKOL branch 3 times, most recently from 26fcff9 to 72547f1 Compare November 23, 2022 10:46
saw-jan
saw-jan reviewed Nov 24, 2022
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SagarGi SagarGi changed the title [tests-only]Refactor MCKOL request to non-existence user and to another users endpoint [tests-only][full-ci]Refactor MCKOL request to non-existence user and to another users endpoint Nov 24, 2022
@SwikritiT
Copy link
Contributor

All the tests are passing the failure is in phpunit tests against sqilte windows.

@phil-davis @individual-it can anyone of you take a look and maybe merge this PR if it's possible?

individual-it
individual-it requested changes Nov 28, 2022
View reviewed changes
tests/TestHelpers/WebDavHelper.php Outdated Show resolved Hide resolved
tests/TestHelpers/WebDavHelper.php Outdated Show resolved Hide resolved
tests/TestHelpers/WebDavHelper.php Outdated Show resolved Hide resolved
@SagarGi SagarGi force-pushed the refactorStatusCodeForMCKOL branch 2 times, most recently from 7b8052a to 4b18149 Compare November 29, 2022 04:05
@phil-davis phil-davis merged commit 4fdd71a into master Nov 30, 2022
@delete-merged-branch delete-merged-branch bot deleted the refactorStatusCodeForMCKOL branch November 30, 2022 03:38
@phil-davis phil-davis mentioned this pull request Nov 30, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan left review comments

@phil-davis phil-davis phil-davis approved these changes

@individual-it individual-it individual-it approved these changes

@amrita-shrestha amrita-shrestha amrita-shrestha approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@kiranparajuli589 kiranparajuli589 Awaiting requested review from kiranparajuli589

Assignees

@SagarGi SagarGi

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@SagarGi @amrita-shrestha @ownclouders @SwikritiT @phil-davis @individual-it @kiranparajuli589 @saw-jan