Return proper error if part file name is too long

[JammingBen]

Description

This is an alternative, less destructive approach than #39088.

With this implementation, we keep the filename limit for part file names and just return a proper error. That means, if you upload a file with 250 chars (filesystem limit is usually 255), then you still get an "filename too long" error because of the part file name added by ownCloud.

This PR also reverts #39088 therefore.

Related Issue

• Fixes https://github.com/owncloud/enterprise/issues/4692

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised: config.sample.php updated with PR 39168 -> run configToDocs command docs#3994
• Changelog item, see TEMPLATE

[JammingBen]

@mrow4a @DeepDiver1975 As discussed, here is the alternative approach for our part file name issue. Please have a look.

[JammingBen]

Please note that by setting part_file_in_storage to false, part files will still get hashed (see https://github.com/owncloud/core/blob/master/apps/dav/lib/Connector/Sabre/File.php#L310)! That means this setting is basically broken because, once again, several apps cannot work with a hashed part file name yet. #39131 would solve this problem though.

[DeepDiver1975]

I see no change from 255 to 250 in this pr.
Am I missing anything? Thx

[JammingBen]

Changing this won't affect anything, because the part file is being written to the filesystem before the length check of the original file. Thus we just added a length check for the part file itself.

[mrow4a]

add quick unit test

[ownclouders]

💥 Acceptance tests pipeline apiProvisioning-v1-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/32162/53/1

[phil-davis]

https://drone.owncloud.com/owncloud/core/32163

There was 1 failure:

1) OCA\DAV\Tests\unit\Connector\Sabre\FileTest::testPutTooLongPartFileName
Failed asserting that exception of type "OCA\DAV\Connector\Sabre\Exception\FileNameTooLong" is thrown.

https://drone.owncloud.com/owncloud/core/32163/32/10

There was 1 failure:

1) OCA\DAV\Tests\unit\Connector\Sabre\FileTest::testPutTooLongPartFileName
Failed asserting that exception of type "OCA\DAV\Connector\Sabre\Exception\FileNameTooLong" is thrown.

These are both errors when running with scality storage. My guess is that scality storage allows longer file names, and so the exception is not thrown in that case.

I am not sure how you can get the file system max filename length from within PHP. If you could do that, then the test could generate a filename a bit longer than the maximum allowed by the current storage. Or maybe tag this test case to skip on scality (however that is done in the unit tests).

[mmattel]

I am not sure how you can get the file system max filename length from within PHP

Maybe this can help a bit...
https://doc.owncloud.com/server/admin_manual/troubleshooting/path_filename_length.html

[JammingBen]

This is not the issue I think as the character limit is hard coded: https://github.com/owncloud/core/blob/master/lib/private/Files/Storage/Common.php#L507. It rather seems that the scality storage does not use part files at all, therefore no exception. Let's see if it succeeds now.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

81.8% Coverage
0.0% Duplication

[phil-davis]

All the failing CI in oC10 apps is passing now. This core change was "a good thing".

[jnweiger]

Tested with owncloud core 10.9.0 beta1

Using the web client: 228 characters is the limit on my testsystem. A file with 229 chars triggers a "filename too long" error. OKayish.
The filesystem at this machine /var/www/owncloud/data/admin/files can handle files with 255 chars, though....