Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] [full-ci] Refactor previews tests so they can run on oC10 or OCIS #39092

Merged
merged 1 commit into from
Aug 3, 2021

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Aug 3, 2021

Description

There are various previews.feature tests that are not being skipped on OCIS. And in the OCIS repo there are versions of some of these tests that are "bug demos". These days we have the expected-failures files. So we can run the "real" tests from core in OCIS CI and add them to expected-failures if they do not pass.

This PR:

  1. Removes the skip tags from all the previews tests, so that they will all run in all CI
  2. Provides two different test scenarios for sizing of previews of files downloaded through the webdav API - the behavior of oC10 is that the exact requested size is returned (even if the request is something "weird" like 1 pixel by 32 pixels). OCIS behaves differently (and more reasonably, depending on how you define "reasonable" - it always returns a width-height that preserves the aspect-ratio of the original file). That is discussed in different output preview dimension from oc10 backend ocis#2069 - and we are accepting that the 2 implementations can have this difference in behavior.

Related Issue

owncloud/ocis#2313

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis self-assigned this Aug 3, 2021
@phil-davis phil-davis changed the title [tests-only] [full-ci] Refactor previes tests so they can run on oC10 or OCIS [tests-only] [full-ci] Refactor previews tests so they can run on oC10 or OCIS Aug 3, 2021
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Aug 3, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants