Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests-Only]Add tests containing [ and ] in path names #38761

Merged
merged 1 commit into from
May 21, 2021
Merged

[Tests-Only]Add tests containing [ and ] in path names #38761

merged 1 commit into from
May 21, 2021

Conversation

jasson99
Copy link
Contributor

@jasson99 jasson99 commented May 20, 2021 •
edited
Loading

Description

This PR adds tests for names containing [ and ] in path names and run the tests in sqlite db

Related Issue

How Has This Been Tested?

  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@jasson99 jasson99 self-assigned this May 20, 2021
@jasson99 jasson99 changed the title Add tests containing [ and ] in path names [Tests-Only]Add tests containing [ and ] in path names May 20, 2021
@owncloud owncloud deleted a comment from update-docs bot May 20, 2021
@jasson99 jasson99 force-pushed the namesWithBracketsInSqlite branch from 83f5579 to 26012ce Compare May 20, 2021 11:53
kiranparajuli589
kiranparajuli589 reviewed May 21, 2021
View reviewed changes
tests/acceptance/features/apiProvisioning-v1/addUser.feature Outdated
Comment on lines 203 to 206
Given the following users have been deleted
| username |
| [user1] |
| [ user2 ] |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 is user deletion really needed before the test? are the users created before the test anywhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NO, they aren't. We had this step in the user creation tests so I sort of followed that. I have removed this part now from my tests.

SwikritiT
SwikritiT reviewed May 21, 2021
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

swoichha
swoichha reviewed May 21, 2021
View reviewed changes
Copy link
Contributor

@swoichha swoichha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jasson99 jasson99 force-pushed the namesWithBracketsInSqlite branch from d18d7fd to eb3f183 Compare May 21, 2021 10:26
@jasson99 jasson99 requested a review from individual-it May 21, 2021 10:27
Talank
Talank reviewed May 21, 2021
View reviewed changes
Copy link
Contributor

@Talank Talank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented May 21, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jasson99 jasson99 merged commit 1ded4c7 into master May 21, 2021
@delete-merged-branch delete-merged-branch bot deleted the namesWithBracketsInSqlite branch May 21, 2021 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SwikritiT SwikritiT SwikritiT left review comments

@kiranparajuli589 kiranparajuli589 kiranparajuli589 left review comments

@Talank Talank Talank left review comments

@swoichha swoichha swoichha left review comments

@individual-it individual-it individual-it approved these changes

@phil-davis phil-davis Awaiting requested review from phil-davis

@dpakach dpakach Awaiting requested review from dpakach

@saw-jan saw-jan Awaiting requested review from saw-jan

Assignees

@jasson99 jasson99

Labels
3 - To Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jasson99 @individual-it @swoichha @Talank @kiranparajuli589 @SwikritiT