[Tests-Only]make escaping/encoding case insensitive

[swoichha]

Description

This PR makes tests of escaped file and folder names with special characters more flexible.

Related Issue

• Fixes Make tests of escaped file and folder names more flexible. #38367

How Has This Been Tested?

• CI

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:
• Changelog item, see TEMPLATE

[dpakach]

do not delete this line this changes line number of other tests

[dpakach]

I think we only want to do this for some properties such as d:href, you can do this only for such properties otherwise do case sensitive comparisioin

[dpakach]

LGTM 👍

[individual-it]

I'm not sure if I'm happy with that, because now we are silently changing the regex and what the codes checks is not what the feature files says.
What about changing the regular expression in the places where its an issue?

[swoichha]

I'm not sure if I'm happy with that, because now we are silently changing the regex and what the codes checks is not what the feature files says.
What about changing the regular expression in the places where its an issue?

@individual-it It was a problem for

core/tests/acceptance/features/apiWebdavProperties2/getFileProperties.feature

Line 39 in b5eadc5

| old | /file ?2.txt | webdav\/file%20%3f2\.txt |

So, this only changes the regex if we are checking response for /d:href like //d:response/d:href in this case. But for all the other cases it does not change the regex into lowercase.

[individual-it]

@swoichha what about changing the regex itself to something like webdav\/file%20%3[fF]2\.txt or adding the case-insensitive modifier i in line 34

core/tests/acceptance/features/apiWebdavProperties2/getFileProperties.feature

Line 34 in b5eadc5

And the value of the item "//d:response/d:href" in the response to user "Alice" should match "/remote\.php\/<expected_href>/"

/webdav\/file%20%3f2\.txt/i

[swoichha]

@swoichha what about changing the regex itself to something like webdav\/file%20%3[fF]2\.txt or adding the case-insensitive modifier i in line 34

core/tests/acceptance/features/apiWebdavProperties2/getFileProperties.feature

Line 34 in b5eadc5

And the value of the item "//d:response/d:href" in the response to user "Alice" should match "/remote\.php\/<expected_href>/"

/webdav\/file%20%3f2\.txt/i

@individual-it Yes, we can do that and it will work but in future we must have to remember doing the same for encoding case-insensitive characters.

[individual-it]

the quoted RFC is for all URIs https://tools.ietf.org/html/rfc3986#section-2.1 so we would have to make the substitution cleverer to match all percent encoding but then we have to be careful not to change if we want to check real % in any item-name

I think the original solution would also match wEBdav\/FiLe%20%3f2\.tXT

[individual-it]

after verbal discussion with @swoichha

/i will also match too much because if the response comes back with the filename with changed cases the test would not catch the bug if we make the regex completely case insensitive
checking the decoded filename is problematic because that would not catch the original bug reported in owncloud/ocis#1296
meaning:

1. we have to check the raw value
2. we have to be explicit what the step does and it should not manipulate the regex or values underneath

so the only real solution is to refactor all regex to be in the form of file%20%3[fF]2

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information