-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set samesite=strict coockies - will work starting php 7.3 #37442
Conversation
6e4ee95
to
fad251e
Compare
Codecov Report
@@ Coverage Diff @@
## master #37442 +/- ##
============================================
- Coverage 64.68% 64.67% -0.01%
- Complexity 19331 19332 +1
============================================
Files 1277 1277
Lines 75514 75521 +7
Branches 1331 1331
============================================
Hits 48846 48846
- Misses 26276 26283 +7
Partials 392 392
Continue to review full report at Codecov.
|
fad251e
to
e3b6780
Compare
e3b6780
to
7dbbfee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 looks good to me.
@DeepDiver1975 override codecov results? I noticed that codecov is not being collected for unit test runs on PHP 7.3 and 7.4 - so that is probably why codecov failed here. I raised PR #37450 to fix that. |
7dbbfee
to
2dd6d55
Compare
PR #37450 was merged. I rebased this - that will be a test of if the extra coverage data makes a different to the codecov results. |
2dd6d55
to
7429797
Compare
From my pov we can ignore the code coverage on this PR. Ready to be merged from my pov. |
Fine with me - someone with privs can override and merge. |
Description
Starting with php7.3 samesite cookies can be set. This PR sets the session cookie to be samesite=stritc.
Related Issue
https://github.com/owncloud/enterprise/issues/3890
How Has This Been Tested?
🤖
Types of changes
Checklist: